Skip to content

WIP: [ON HOLD]Implement new get request subscription endpoint #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: [ON HOLD]Implement new get request subscription endpoint #979

wants to merge 1 commit into from

Conversation

@glaucioripol
Copy link

@glaucioripol glaucioripol commented Jan 26, 2024 •
edited
Loading

Description

It will be on hold because the team that we have dependencies has stopped with their side.
https://farfetch.atlassian.net/browse/FPSCOMMSS-433

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

  • [MAIN] - [package: client] - add @depracated to packages/client/src/subscriptions/getSubscriptions.ts
  • [MAIN] - [package: client] - Create a file with new types to get a subscription. file-path packages/client/src/subscriptions/types/getSubscriptions.vnext.types.ts
  • [MAIN] - [package: client] - Exporting new types for the getSubscriptionVnext into types folder: file-path: packages/client/src/subscriptions/types/index.ts
  • [MAIN] - [package: client] - Creating client method getSubscriptionsVNext
  • [MAIN] - [package: client] - Creating tests to client method getSubscriptionsVNext
  • [MAIN] - [package: client] - create a mock to test the new client method
  • [MAIN] - [package: client] - Create fixtures to help write tests
  • [MAIN] - [package: client] - export the new method in the index module file
  • [MAIN] - [package: redux] - Create actions types related to the new request method
  • [MAIN] - [package: redux] - Create action factory to getSubsctions vnext
  • [MAIN] - [package: redux] - create a file to inject the client in the factory and export
  • [MAIN] - [package: redux] - Create a redux store or increment in packages/redux/src/subscriptions/reducer/userSubscriptions.ts
  • [MAIN] - [package: redux] - add tests for the new subscription store
  • [MAIN] - [package: redux] - create hooks, selectors, and business logic for new store
    Ask about the final endpoint, the current is strange -> https://developers.farfetchplatform.com/Subscriptions

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@glaucioripol glaucioripol self-assigned this Jan 26, 2024
@github-actions github-actions bot added 📦 client Relative to the `@farfetch/blackout-client` package 📦 redux Relative to the `@farfetch/blackout-redux` package labels Jan 26, 2024
@glaucioripol glaucioripol changed the title WIP: Implement new get request subscription endpoint WIP: [ON HOLD]Implement new get request subscription endpoint Jan 29, 2024
@dnamorim dnamorim added this to the dev-main-13-02-24 milestone Feb 6, 2024
@dnamorim dnamorim changed the base branch from main to dev-main-13-02-24 February 6, 2024 17:11
Base automatically changed from dev-main-13-02-24 to main February 14, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glaucioripol glaucioripol

Labels

📦 client Relative to the `@farfetch/blackout-client` package 📦 redux Relative to the `@farfetch/blackout-redux` package

Milestone

dev-main-13-02-24

Development

Successfully merging this pull request may close these issues.

3 participants

@glaucioripol @dnamorim