Include message offset into logs #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epbensimpson
approved these changes
Mar 18, 2025
brmagadutra
approved these changes
Mar 19, 2025
martinhonovais
approved these changes
Mar 24, 2025
luispfgarces
approved these changes
Mar 24, 2025
Contributor
Author
|
Great, thanks! Can we have a release, too? ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When investigating "stuck in retry" situations it is often required to look up the message that causes retries, and for that knowing the offset is useful.
Unfortunately, currently the Retry middleware only logs the partition number and not the offset of the message in question.
This PR is to add message offset to the logs.