-
Notifications
You must be signed in to change notification settings - Fork 272
Rewrite library with TypeScript, update to modern React & Jest conventions #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite library with TypeScript, update to modern React & Jest conventions #581
Conversation
|
NOTE: this is currently targeting I have (for now) included updates for the version from |
cbb4b88 to
ff72b73
Compare
|
Looking forward for this merge. Is is published in npm already? Thanks for the greate work @charles4221 |
@olmobrutall it is not published to npm yet as this is still a draft PR. It is 99% ready, we just need to have a discussion around what the next major version will be (e.g. 0.3.0, or 1.0.0, or 3.0.0) I will be looking to take on maintainer duties for this repository but still need to discuss the details of that with the FontAwesome team before anything happens. |
baf61cc to
6c166ad
Compare
9b43bfd to
61b2f6d
Compare
5d42a50 to
26ee89a
Compare
0a4e55f to
1391726
Compare
1391726 to
fce9a20
Compare
dc4ee57 to
6f57fc7
Compare
robmadole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely fantastic! Great attention to detail here.
I can't thank you enough @charles4221. I think and hope the community "reacts" well to this. (Sorry for the Dad joke)
rollupwithtsupfor providing both ESM and CJS exports from one TypeScript sourceprop-typesin favour of colocated typings for React component propseslintfrom v6 to v9, rewrote config as Flat Config, modernised ESLint config, plugins and rulesreact-test-rendererto the industry standard@testing-library/react