Implement Password Strength Meter for the Set Password Form #809
Conversation
|
@EbukaMoses is attempting to deploy a commit to the Essencium Frontend Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lwydra
left a comment
lwydra
left a comment
There was a problem hiding this comment.
Looking good aside from the translation key, thank you for your contribution!
One minor thing in addition, could you please adjust your commit message to adhere to conventional commits? See our CONTRIBUTION.md for details
|
|
||
| <Button fullWidth type="submit"> | ||
| <Text size="sm" c="dimmed" mt={-8}> | ||
| {t('setPasswordView.form.passwordRequirements')} |
There was a problem hiding this comment.
This translation key does not exist, could you please take a look?
There was a problem hiding this comment.
Hi @lwydra
i would appreciate a clearer explanation here.
There was a problem hiding this comment.
The key setPasswordView.form.passwordRequirements does not exist in our translation files, leading to the key itself being rendered what is not very useful:
If you search for common.json, you will find our current translation files for german and english
2 participants
DESCRIPTION
description of the scope of this PR
loom link if applicable
TO-DO
main& resolve merge conflictsCLOSES
closes list of issues closed in this PR