Skip to content

fix(metrics): invalid metric initialization causing alerts #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(metrics): invalid metric initialization causing alerts #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f92eb
fix(metrics): invalid metric initialization causing alerts
rymnc Nov 5, 2025
6457712
fix: clippy
rymnc Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions committer/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ async fn main() -> Result<()> {
&config,
&internal_config,
&metrics_registry,
finalization_metric.clone(),
)?
} else if config.da_layer.is_some() {
setup::eigen_da_services(
Expand All @@ -81,6 +82,7 @@ async fn main() -> Result<()> {
&config,
&internal_config,
&metrics_registry,
finalization_metric,
)
.await?
} else {
Expand Down
7 changes: 5 additions & 2 deletions committer/src/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ pub fn block_committer(
)
}

#[allow(clippy::too_many_arguments)]
pub fn ethereum_da_services(
fuel: FuelApi,
ethereum_rpc: L1,
Expand All @@ -86,6 +87,7 @@ pub fn ethereum_da_services(
config: &config::Config,
internal_config: &config::Internal,
registry: &Registry,
last_finalization: IntGauge,
) -> Result<Vec<tokio::task::JoinHandle<()>>> {
let block_bundler = block_bundler(
fuel.clone(),
Expand Down Expand Up @@ -119,7 +121,7 @@ pub fn ethereum_da_services(
cancel_token.clone(),
registry,
config,
last_finalization_metric(),
last_finalization.clone(),
);

let state_importer_handle = block_importer(
Expand Down Expand Up @@ -152,6 +154,7 @@ pub async fn eigen_da_services(
config: &config::Config,
internal_config: &config::Internal,
registry: &Registry,
last_finalization: IntGauge,
) -> Result<Vec<tokio::task::JoinHandle<()>>> {
let block_bundler = eigen_block_bundler(
fuel.clone(),
Expand Down Expand Up @@ -180,7 +183,7 @@ pub async fn eigen_da_services(
cancel_token.clone(),
config,
registry,
last_finalization_metric(),
last_finalization.clone(),
)?;

let fee_metrics_handle =
Expand Down
Loading