Feature: magnets module #2287

CoronelBuendia · 2023-05-30T10:15:17Z

Linked Issues

Closes #{ID}

Description

⚠️ WIP ⚠️

Draft PR to provide visibility on the updates to the magnets module feature branch.

Needs:

Interface Changes

Checklist

I confirm that I have completed the following checks:

Tests run locally and pass pytest tests --reactor
Code quality checks run locally and pass flake8 and black .
Documentation built locally and checked sphinx-build -W documentation/source documentation/build

github-actions · 2023-05-30T10:35:22Z

[Errno 2] No such file or directory: 'PR_report/.report.json'

codecov · 2023-05-30T10:36:27Z

Codecov Report

❌ Patch coverage is 45.59585% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.35%. Comparing base (359e50c) to head (d98c148).

Files with missing lines	Patch %	Lines
bluemira/magnets/fatigue.py	35.40%	104 Missing ⚠️
bluemira/magnets/solenoid_tools.py	96.87%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2287      +/-   ##
===========================================
- Coverage    77.56%   77.35%   -0.21%     
===========================================
  Files          247      249       +2     
  Lines        29422    29615     +193     
===========================================
+ Hits         22822    22910      +88     
- Misses        6600     6705     +105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sonarqubecloud · 2023-05-30T11:45:50Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonarqubecloud · 2023-10-05T07:49:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonarqubecloud · 2024-01-17T04:52:55Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-11-05T16:35:53Z

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (4)

On runtest

/home/runner/work/bluemira/bluemira/bluemira/codes/process/api.py:150: DeprecationWarning: path is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.

On collect

/home/runner/work/bluemira/process/process/io/python_fortran_dicts.py:9: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
/home/runner/miniconda3/envs/bluemira/lib/python3.11/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('cherab'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
/home/runner/miniconda3/envs/bluemira/lib/python3.11/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('sphinxcontrib'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages

sonarqubecloud · 2024-12-06T09:27:40Z

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-02-04T11:54:54Z

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-04-24T15:27:41Z

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

* add solenoid tools file * first pass max field * first pass hoop stress * flake8 * max flux * rename * docstrings * axial stress start * replace estimate with calculation * remove temp scaffolding * flake8 * add test * flkae8 * add livingstone test

* examples in docs * whoops * fatigue dataclasses * docstrings * start * pasue * urgh * finish semi-elliptical * flake8 * reshuffle * embedded crack * quarter crack and clean up * docstrings * docstrings * flake8 * add TODO * minor * add test file * add test file * equation checks * units * docstring and __all__ * flake8 * start ruffing * ruff * typo

sonarqubecloud · 2025-08-22T11:18:59Z

Quality Gate passed

Issues
23 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

CoronelBuendia requested a review from a team as a code owner May 30, 2023 10:15

CoronelBuendia added this to the Version X.X.X milestone May 30, 2023

je-cook modified the milestones: Version 1.5.0, Version 1.X.X Jul 6, 2023

je-cook modified the milestones: Version 1.6.0, Version 1.X.X Aug 22, 2023

je-cook modified the milestones: Version 1.7.0, Version 1.8.0 Oct 4, 2023

je-cook force-pushed the develop branch from 5bc9cf3 to 0e08d7f Compare November 2, 2023 13:03

je-cook modified the milestones: Version 1.8.0, Version 2.0.0 Nov 8, 2023

CoronelBuendia force-pushed the feature/new_magnet_module branch from 54612af to 49cf679 Compare January 17, 2024 04:52

je-cook modified the milestones: Version 1.9.0, Version 1.X.X Feb 8, 2024

je-cook force-pushed the develop branch 5 times, most recently from 5a50acb to 7574352 Compare May 15, 2024 08:13

je-cook force-pushed the feature/new_magnet_module branch from 49cf679 to 83e18c2 Compare June 3, 2024 06:01

je-cook marked this pull request as draft June 3, 2024 06:01

je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from fb72b27 to d33aa03 Compare June 4, 2024 06:19

je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from 11df9c6 to 3465d37 Compare June 24, 2024 11:41

je-cook force-pushed the feature/new_magnet_module branch from 1d64c5d to ed7b8c1 Compare October 10, 2024 09:30

je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from 57bbfbc to 0434b80 Compare October 22, 2024 12:36

je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from 3cd4a11 to 2b50956 Compare November 5, 2024 16:22

je-cook force-pushed the feature/new_magnet_module branch from 2b50956 to 7523fb6 Compare November 18, 2024 12:52

je-cook force-pushed the feature/new_magnet_module branch from 7523fb6 to 8600a87 Compare December 2, 2024 12:00

je-cook force-pushed the develop branch from 2672dd0 to 4af381e Compare December 4, 2024 11:09

je-cook force-pushed the feature/new_magnet_module branch from 8600a87 to ceb8692 Compare December 6, 2024 09:26

je-cook force-pushed the feature/new_magnet_module branch from ceb8692 to 304b8e1 Compare February 4, 2025 11:54

je-cook force-pushed the feature/new_magnet_module branch from 304b8e1 to 3737f51 Compare April 24, 2025 15:26

CoronelBuendia and others added 11 commits August 22, 2025 11:19

new module folders

2388f69

add example skeleton

7135c96

add documentation folder

780eeaf

readme entry

6c43809

add to index

b039aca

examples in docs

5ef8abb

update CODEOWNERS for magnets

383f74a

CS title

1a759ac

Magnet solenoid tools (#2304)

58c6a68

* add solenoid tools file * first pass max field * first pass hoop stress * flake8 * max flux * rename * docstrings * axial stress start * replace estimate with calculation * remove temp scaffolding * flake8 * add test * flkae8 * add livingstone test

licence header

4ff5b93

🚨 Ruff fixes

2edb0a1

CoronelBuendia force-pushed the feature/new_magnet_module branch from 3737f51 to 2edb0a1 Compare August 22, 2025 09:19

CoronelBuendia changed the title ~~Feature/new magnets module~~ Feature: magnets module Aug 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature: magnets module #2287

Feature: magnets module #2287

Uh oh!

CoronelBuendia commented May 30, 2023 •

edited

Loading

Uh oh!

github-actions bot commented May 30, 2023 •

edited

Loading

Uh oh!

codecov bot commented May 30, 2023 •

edited

Loading

Uh oh!

sonarqubecloud bot commented May 30, 2023

Uh oh!

sonarqubecloud bot commented Oct 5, 2023

Uh oh!

sonarqubecloud bot commented Jan 17, 2024

Uh oh!

github-actions bot commented Nov 5, 2024 •

edited

Loading

On runtest

On collect

Uh oh!

sonarqubecloud bot commented Dec 6, 2024

Uh oh!

sonarqubecloud bot commented Feb 4, 2025

Uh oh!

sonarqubecloud bot commented Apr 24, 2025

Uh oh!

sonarqubecloud bot commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feature: magnets module #2287

Are you sure you want to change the base?

Feature: magnets module #2287

Uh oh!

Conversation

CoronelBuendia commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues

Description

Interface Changes

Checklist

Uh oh!

github-actions bot commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented May 30, 2023

Uh oh!

sonarqubecloud bot commented Oct 5, 2023

Uh oh!

sonarqubecloud bot commented Jan 17, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warning Report

On runtest

On collect

Uh oh!

sonarqubecloud bot commented Dec 6, 2024

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Feb 4, 2025

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Apr 24, 2025

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Aug 22, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CoronelBuendia commented May 30, 2023 •

edited

Loading

github-actions bot commented May 30, 2023 •

edited

Loading

codecov bot commented May 30, 2023 •

edited

Loading

github-actions bot commented Nov 5, 2024 •

edited

Loading