Skip to content

Conversation

@je-cook
Copy link
Contributor

@je-cook je-cook commented Apr 23, 2025

Linked issue

Hopefully closes #3658

Description

This PR regrid an eqdsk after it has been read into an equilibrium object.
TODO

  • rescale psi
  • needs testing

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added enhancement New feature or request equilibria Tasks relating to the equilibria module labels Apr 23, 2025
@je-cook je-cook force-pushed the je-cook/regrid_on_read branch from 035f69c to 76b124b Compare April 24, 2025 15:09
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.97%. Comparing base (447515f) to head (f12bf7d).

Files with missing lines Patch % Lines
bluemira/equilibria/plasma.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3890      +/-   ##
===========================================
+ Coverage    78.95%   78.97%   +0.02%     
===========================================
  Files          244      244              
  Lines        29322    29347      +25     
===========================================
+ Hits         23150    23178      +28     
+ Misses        6172     6169       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (1)

On collect

  • /home/runner/work/bluemira/bluemira/bluemira/codes/openmc/solver.py:60: DeprecationWarning: In 3.13 the default auto()/generate_next_value will require all values to be sortable and support adding +1 and the value returned will be the largest value in the enum incremented by 1

@sonarqubecloud
Copy link

@je-cook je-cook force-pushed the je-cook/regrid_on_read branch from ed086c3 to f12bf7d Compare December 5, 2025 10:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@je-cook je-cook marked this pull request as ready for review December 5, 2025 10:43
@je-cook je-cook requested a review from a team as a code owner December 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request equilibria Tasks relating to the equilibria module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset grid for eqdsk.

4 participants