-
Notifications
You must be signed in to change notification settings - Fork 24
WIP: Add ParameterFrame usage to magnet module classes #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ivanmaione/magnet_module
Are you sure you want to change the base?
Conversation
…k, parallel_r, parallel_k with general summation and reciprocal_summation functions
… case_tf and conductor files
…inheritance for cables
7bc321e to
f371824
Compare
baf7042 to
be4ec03
Compare
…rather than full width
…he material directly
1da3d6b to
2ecaca0
Compare
aa148ab to
4bd7013
Compare
|
One change that we havent done here that should be up for discussion is dx usually is half width and height etc in the rest of BM here it is full width |
Sort of done 6 iterations, visually the same slightly different error, TODOs scattered for possible sources
Tests pass locally, coverage is probably not great
|
|



Linked Issues
Closes #{ID}
Description
Add some ParameterFrame dataclasses to magnet module. Need to sort out how classes are created from dictionaries so done in same was as elsewhere in bluemira rather than through registry method. Can then use parameterframes in examples and tests.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build