Skip to content

Conversation

@kj5248
Copy link
Contributor

@kj5248 kj5248 commented Aug 21, 2025

Linked Issues

Closes #{ID}

Description

Add some ParameterFrame dataclasses to magnet module. Need to sort out how classes are created from dictionaries so done in same was as elsewhere in bluemira rather than through registry method. Can then use parameterframes in examples and tests.

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@kj5248 kj5248 requested a review from a team as a code owner August 21, 2025 13:59
@je-cook je-cook force-pushed the jmatthews/parameter-frame branch from 7bc321e to f371824 Compare August 27, 2025 07:29
@je-cook je-cook requested review from a team as code owners August 27, 2025 07:29
@je-cook je-cook changed the base branch from ivanmaione/magnet_module to matti/materials_for_magnet_module August 27, 2025 07:34
@je-cook je-cook removed request for a team August 27, 2025 07:34
@CoronelBuendia CoronelBuendia force-pushed the matti/materials_for_magnet_module branch from baf7042 to be4ec03 Compare August 27, 2025 08:32
@CoronelBuendia CoronelBuendia requested a review from a team as a code owner August 27, 2025 08:32
@je-cook je-cook force-pushed the jmatthews/parameter-frame branch from 1da3d6b to 2ecaca0 Compare September 10, 2025 16:09
Base automatically changed from matti/materials_for_magnet_module to ivanmaione/magnet_module September 11, 2025 13:26
@je-cook je-cook force-pushed the jmatthews/parameter-frame branch from aa148ab to 4bd7013 Compare September 11, 2025 14:17
@je-cook
Copy link
Contributor

je-cook commented Sep 12, 2025

One change that we havent done here that should be up for discussion is dx usually is half width and height etc in the rest of BM here it is full width

@je-cook
Copy link
Contributor

je-cook commented Sep 12, 2025

Current state of work:

  • rework with parameter frames is done

  • simple example works (example_tf_creation.py) as expected

  • example result matches initial work

Sort of done 6 iterations, visually the same slightly different error, TODOs scattered for possible sources

  • change tests to work with parameter frames

Tests pass locally, coverage is probably not great

To check/do:

  • configure designer to not just output the case object but to be able to output wires for use in builders
  • fatigue model hasn't really been integrated and not sure if that is needed

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants