Skip to content

Conversation

@je-cook
Copy link
Contributor

@je-cook je-cook commented Aug 27, 2025

Linked Issues

Closes #{ID}

Description

I had a mishap with running ruff a directory too high (therefore no config). Undoing this fixed some trailing comma formatting changes that weren't caught before

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added the quality Tasks relating to quality issues or improvements label Aug 27, 2025
@je-cook je-cook requested review from a team as code owners August 27, 2025 09:58
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 87.21805% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.56%. Comparing base (359e50c) to head (391b329).
⚠️ Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/geometry/parameterisations.py 40.00% 3 Missing ⚠️
bluemira/codes/openmc/solver.py 0.00% 2 Missing ⚠️
bluemira/equilibria/find_legs.py 71.42% 2 Missing ⚠️
bluemira/codes/openmc/make_csg.py 0.00% 1 Missing ⚠️
bluemira/display/plotter.py 50.00% 1 Missing ⚠️
bluemira/equilibria/analysis.py 80.00% 1 Missing ⚠️
bluemira/equilibria/plotting.py 0.00% 1 Missing ⚠️
bluemira/equilibria/run.py 0.00% 1 Missing ⚠️
bluemira/fuel_cycle/analysis.py 0.00% 1 Missing ⚠️
...ira/radiation_transport/neutronics/blanket_data.py 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4060   +/-   ##
========================================
  Coverage    77.56%   77.56%           
========================================
  Files          247      247           
  Lines        29422    29422           
========================================
  Hits         22822    22822           
  Misses        6600     6600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

⚠️ Warning Report

Found 4 warnings.

All warnings (4)

On collect

  • /home/runner/work/bluemira/process/process/io/python_fortran_dicts.py:9: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  • /home/runner/miniconda3/envs/bluemira/lib/python3.11/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('sphinxcontrib'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
  • /home/runner/miniconda3/envs/bluemira/lib/python3.11/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('cherab'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages

On runtest

  • /home/runner/work/bluemira/bluemira/bluemira/codes/process/api.py:150: DeprecationWarning: path is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality Tasks relating to quality issues or improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants