Skip to content

Conversation

@je-cook
Copy link
Contributor

@je-cook je-cook commented Dec 1, 2025

Linked Issues

Closes #3587

Description

Adds a label for the tilt and a comment for the tension args. The label can be seen on polyspline in the docs.

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook requested a review from a team as a code owner December 1, 2025 07:47
@je-cook je-cook added documentation Improvements or additions to documentation geometry Tasks relating to the geometry module labels Dec 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.94%. Comparing base (0b5a3ec) to head (00159f9).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/geometry/parameterisations.py 17.64% 14 Missing ⚠️

❌ Your patch check has failed because the patch coverage (17.64%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4163      +/-   ##
===========================================
+ Coverage    78.86%   78.94%   +0.07%     
===========================================
  Files          244      244              
  Lines        29293    29318      +25     
===========================================
+ Hits         23103    23146      +43     
+ Misses        6190     6172      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (1)

On collect

  • /home/runner/work/bluemira/bluemira/bluemira/codes/openmc/solver.py:60: DeprecationWarning: In 3.13 the default auto()/generate_next_value will require all values to be sortable and support adding +1 and the value returned will be the largest value in the enum incremented by 1

@CoronelBuendia CoronelBuendia merged commit 406e126 into develop Dec 5, 2025
19 of 21 checks passed
@CoronelBuendia CoronelBuendia deleted the je-cook/label_polyspine branch December 5, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation geometry Tasks relating to the geometry module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add labels for l0s - l3s l03 -l3e for PolySpline

3 participants