Skip to content

Conversation

@geograham
Copy link
Contributor

Description

Constraints/Targets not updating - deepcopy in dummy eq set up, and if deepcopy of eq used between setting up optimisation problem and the Picard iterator resulted in disconnection.

Interface Changes

PicardIterator no longer takes eq as input. Does not need to, as we have the COP (with relevant eq) as input.

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.68%. Comparing base (447515f) to head (01bc3af).

Files with missing lines Patch % Lines
bluemira/equilibria/run.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4170      +/-   ##
===========================================
- Coverage    78.95%   78.68%   -0.28%     
===========================================
  Files          244      244              
  Lines        29322    29320       -2     
===========================================
- Hits         23150    23069      -81     
- Misses        6172     6251      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (1)

On collect

  • /home/runner/work/bluemira/bluemira/bluemira/codes/openmc/solver.py:60: DeprecationWarning: In 3.13 the default auto()/generate_next_value will require all values to be sortable and support adding +1 and the value returned will be the largest value in the enum incremented by 1

@je-cook je-cook added equilibria Tasks relating to the equilibria module optimisation Tasks relating to optimisation labels Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

equilibria Tasks relating to the equilibria module optimisation Tasks relating to optimisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants