Skip to content

Conversation

@athoynilimanew
Copy link
Contributor

@athoynilimanew athoynilimanew commented Dec 10, 2025

Linked Issues

Closes #3656

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@athoynilimanew athoynilimanew requested a review from a team as a code owner December 10, 2025 11:03
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.68%. Comparing base (447515f) to head (5c668af).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/mesh/meshing.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4171      +/-   ##
===========================================
- Coverage    78.95%   78.68%   -0.27%     
===========================================
  Files          244      244              
  Lines        29322    29335      +13     
===========================================
- Hits         23150    23082      -68     
- Misses        6172     6253      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (1)

On collect

  • /home/runner/work/bluemira/bluemira/bluemira/codes/openmc/solver.py:60: DeprecationWarning: In 3.13 the default auto()/generate_next_value will require all values to be sortable and support adding +1 and the value returned will be the largest value in the enum incremented by 1

Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks, could you just remove this comment too.

@je-cook je-cook added the meshing Tasks relating to the meshing module label Dec 10, 2025
@je-cook je-cook self-assigned this Dec 10, 2025
@sonarqubecloud
Copy link

@je-cook je-cook enabled auto-merge (squash) December 10, 2025 13:19
@je-cook je-cook disabled auto-merge December 10, 2025 13:19
@je-cook je-cook enabled auto-merge (squash) December 10, 2025 13:19
@je-cook je-cook merged commit 7c92658 into Fusion-Power-Plant-Framework:develop Dec 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meshing Tasks relating to the meshing module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check mesh file input type

2 participants