Skip to content

Conversation

@geograham
Copy link
Contributor

@geograham geograham commented Dec 10, 2025

Linked Issues

Closes #4161

Note for reviewer: I had thought this might be used in which_legs of Legflux but I am not sure.

Image below, to show rough use - checking for intersections between the closed flux surface and a tangent line at the x-point.

image

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@geograham geograham requested review from a team as code owners December 10, 2025 13:20
@je-cook je-cook added the equilibria Tasks relating to the equilibria module label Dec 10, 2025
@je-cook je-cook self-assigned this Dec 10, 2025
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.69%. Comparing base (447515f) to head (fb794f3).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4172      +/-   ##
===========================================
- Coverage    78.95%   78.69%   -0.26%     
===========================================
  Files          244      244              
  Lines        29322    29352      +30     
===========================================
- Hits         23150    23099      -51     
- Misses        6172     6253      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (1)

On collect

  • /home/runner/work/bluemira/bluemira/bluemira/codes/openmc/solver.py:60: DeprecationWarning: In 3.13 the default auto()/generate_next_value will require all values to be sortable and support adding +1 and the value returned will be the largest value in the enum incremented by 1

Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@je-cook je-cook merged commit d139331 into Fusion-Power-Plant-Framework:develop Dec 10, 2025
14 checks passed
@geograham geograham mentioned this pull request Dec 11, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

equilibria Tasks relating to the equilibria module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalise flux surface functions that rely on x-point z checks

2 participants