[CHA-0] Add getter methods, equals and hashCode to most request classes for better testability
#205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaljam
force-pushed
the
getter-hashcode-request
branch
3 times, most recently
from
1a3bfb6 to
e44dc6d
Compare
better testablity also fixed getter missing in javadoc
shaljam
force-pushed
the
getter-hashcode-request
branch
from
e44dc6d to
83ae1a0
Compare
hifaizsk
approved these changes
Oct 15, 2025
adityaalifn
added a commit
that referenced
this pull request
Oct 22, 2025
…ization The ObjectMapper configuration added in PR #205 set PropertyAccessor.GETTER visibility to NONE, which disabled ALL getter methods including those annotated with @JsonAnyGetter. This broke serialization of additionalFields in channels and messages, causing custom object fields to appear as empty. Changed to use field-based serialization while still respecting explicit Jackson annotations (@JsonAnyGetter, @JsonProperty, etc): - Set PropertyAccessor.ALL to NONE (disable auto-detection) - Set PropertyAccessor.FIELD to ANY (use field-based serialization) This preserves the intent of PR #205 (avoiding getter auto-detection) while fixing additionalFields serialization. Fixes: #205
3 tasks
adityaalifn
added a commit
that referenced
this pull request
Oct 22, 2025
…ization (#209) The ObjectMapper configuration added in PR #205 set PropertyAccessor.GETTER visibility to NONE, which disabled ALL getter methods including those annotated with @JsonAnyGetter. This broke serialization of additionalFields in channels and messages, causing custom object fields to appear as empty. Changed to use field-based serialization while still respecting explicit Jackson annotations (@JsonAnyGetter, @JsonProperty, etc): - Set PropertyAccessor.ALL to NONE (disable auto-detection) - Set PropertyAccessor.FIELD to ANY (use field-based serialization) This preserves the intent of PR #205 (avoiding getter auto-detection) while fixing additionalFields serialization. Fixes: #205
Merged
adityaalifn
added a commit
that referenced
this pull request
Oct 22, 2025
…ization The ObjectMapper configuration added in PR #205 set PropertyAccessor.GETTER visibility to NONE, which disabled ALL getter methods including those annotated with @JsonAnyGetter. This broke serialization of additionalFields in channels and messages, causing custom object fields to appear as empty. Changed to use field-based serialization while still respecting explicit Jackson annotations (@JsonAnyGetter, @JsonProperty, etc): - Set PropertyAccessor.ALL to NONE (disable auto-detection) - Set PropertyAccessor.FIELD to ANY (use field-based serialization) This preserves the intent of PR #205 (avoiding getter auto-detection) while fixing additionalFields serialization. Fixes: #205
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
It is possible to get the fields on request objects. Also fixed getter methods missing in the javadoc.