chore: pass secret config around instead of discrete args #982
Conversation
gg-mmill
force-pushed
the
mmillet/pass_config_around
branch
2 times, most recently
from
b7a8bac to
7ee194c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 91.49% 91.58% +0.08%
==========================================
Files 180 180
Lines 7597 7605 +8
==========================================
+ Hits 6951 6965 +14
+ Misses 646 640 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gg-mmill
force-pushed
the
mmillet/pass_config_around
branch
from
7ee194c to
382c3c8
Compare
gg-mmill
force-pushed
the
mmillet/pass_config_around
branch
4 times, most recently
from
084299e to
dd27878
Compare
gg-mmill
force-pushed
the
mmillet/pass_config_around
branch
from
dd27878 to
1b2bd9a
Compare
gg-mmill
changed the title
agateau-gg
left a comment
agateau-gg
left a comment
There was a problem hiding this comment.
One minor remark, looks good otherwise.
| def __init__( | ||
| self, show_secrets: bool = False, ignore_known_secrets: bool = False | ||
| ) -> None: | ||
| def __init__(self, *args: Any, **kwargs: Any) -> None: |
There was a problem hiding this comment.
I am not fond of this because it prevents type-hinting checks.
There was a problem hiding this comment.
Ok, removing the __init__ method entirely. The only impact is that verbose could be set to True, while unused by the SecretGitLabWebUIOutputHandler, but that doesn't seem like a real issue.
There was a problem hiding this comment.
Or should I copy the other arguments in the SecretGitLabWebUIOutputHandler ?
What has been done
Refactor how secret scan parameters are passed around: pass the SecretConfig around, instead of discrete args (both to the scanner, and in output handlers).
Validation
There should be no functional change.