fix(precommit): handle filenames with spaces in Commit.from_merge #992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using
git mergewith a file which has a space in its name, the command fails with the error :What has been done
Since the path is at the end of the parsed line (whose other components do not include spaces), we can simple add
maxsplit=3as an argument to split.Validation
git merge <other_branch>git merge --continueIf there is no error, it means the bug is fixed.
PR check list
skip-changeloglabel has been added to the PR.