Seq: Add --terminator flag #150
Conversation
GrayJack
left a comment
GrayJack
left a comment
There was a problem hiding this comment.
Thanks for contributing!! 🎉
I leave some comments for you.
The format check is failing, but don't worry, if you're unable to use nightly compiler to format the code (sadly our config still requires some unstable rustfmt features), after you apply the final changes to solve my comments I'll format the code before merging
seq/src/cli.rs
Outdated
| Arg::with_name("TERMINATOR") | ||
| .short("t") | ||
| .long("terminator") | ||
| .help("Terminator of the values") |
There was a problem hiding this comment.
You missed a dot at the end of the string
seq/src/main.rs
Outdated
| print!("{}", val); | ||
| } | ||
| println!(); | ||
| print!("\n{}", terminator); |
There was a problem hiding this comment.
You're print a newline before printing the terminator. If I remember correctly (almost 2 years since I had used FreeBSD seq), the behavior would to just print the terminator
|
Hey, I pushed another version, would you please take a look at it? I tried to format it with rust fmt. Thank you! |
|
bors r+ |
|
Awesome, would you please put the |
2 participants
Issue #63