Marshal String Encodings #1283
Open
Marshal String Encodings #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 22, 2025 15:15
tobil4sk
reviewed
Dec 24, 2025
|
|
||
| <file name = "src/cpp/encoding/Ascii.cpp"/> | ||
| <file name = "src/cpp/encoding/Utf8.cpp"/> | ||
| <file name = "src/cpp/encoding/Utf16.cpp"/> |
Member
There was a problem hiding this comment.
I think it would be better to include these in the build only if the types are actually needed by haxe. They are more like utilities rather than something that should be a mandatory part of the runtime group.
Contributor
Author
There was a problem hiding this comment.
I'll look into it. Another thing I was thinking of was changing string.cpp to use these functions as well since there's a fair bit of duplication here, plus the functions in these classes deal with some things the string.cpp ones don't (various utf-8 ranges are invalid).
I need to check the performance characteristics though, since all these functions are bound checked whereas string.cpp works on raw pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details on haxe side : HaxeFoundation/haxe#12476