Skip to content

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Oct 6, 2025

What this PR does / why we need it:

Ignores the following line when calculating code coverage:

Screenshot 2025-10-06 at 2 42 26 PM

Which issue(s) this PR closes:

None. Relates to:

Special notes for your reviewer:

If we can write a test to exercise logOut, that would probably be better.

Suggestions on how to test this:

Interact with the header.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes or changelog update needed for this change?:

No.

Additional documentation:

None.

@pdurbin pdurbin added the GREI Re-arch GREI re-architecture-related label Oct 6, 2025
@pdurbin pdurbin moved this to Ready for Review ⏩ in IQSS Dataverse Project Oct 6, 2025
@pdurbin pdurbin added the Size: 0.5 A percentage of a sprint. 0.35 hours label Oct 6, 2025
@coveralls
Copy link

Coverage Status

coverage: 97.232% (+0.08%) from 97.156%
when pulling f314d3f on ignore-logout-for-code-coverage
into 905d610 on develop.

@pdurbin
Copy link
Member Author

pdurbin commented Oct 8, 2025

If we can write a test to exercise logOut, that would probably be better.

I spoke with @g-saracca and he's pretty sure we can write such a test. If we come up with a better way to cover this line instead of ignoring it, please feel free to close this PR! 😅

@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
@g-saracca
Copy link
Contributor

@pdurbin PR to improve coverage ready here.
This is the line covering this logout case for example.

@pdurbin
Copy link
Member Author

pdurbin commented Oct 9, 2025

@g-saracca fantastic! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) GREI Re-arch GREI re-architecture-related Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants