fix(ImageViewer): Resolve file download issue https://github.com/IceWhaleTech/CasaOS/issues/2210 #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `ImageViewer.vue` component, the original download functionality utilized the mixin's download function, which relied on `props.item.path`. This path remains static and isn't updated by the `next` and `prev` functions, leading to incorrect file downloads. To fix this, the download function in `ImageViewer.vue` has been overridden. The updated implementation now uses `data.currentItem.path`, which dynamically changes with the `next` and `prev` functions, ensuring accurate file downloads.
guquan-lengyue
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ImageViewer.vuecomponent, the original download functionality utilized the mixin's download function, which relied onprops.item.path. This path remains static and isn't updated by thenextandprevfunctions, leading to incorrect file downloads.To fix this, the download function in
ImageViewer.vuehas been overridden. The updated implementation now usesdata.currentItem.path, which dynamically changes with thenextandprevfunctions, ensuring accurate file downloads.Close #2210