Skip to content
This repository was archived by the owner on Jun 12, 2021. It is now read-only.

Conversation

@nsklikas
Copy link
Contributor

The current code would overwrite the per client usage_rules. E.g.:

# The grant created here will take the usage_rules defined in the client
sid = endpoint_context.session_manager.create_session(
    ..., 
    token_usage_rules=endpoint_context.authz.usage_rules(auth_req.get("client_id")
)
# This calls endpoint_context.authz(...), which would overwrite the usage_rules (with the 
# global ones)
endpoint_context.endpoint["authorization"].authz_part2(auth_req, sid)

This PR fixes this behaviour.

@nsklikas nsklikas requested review from angelakis and rohe April 21, 2021 09:51
@rohe
Copy link
Contributor

rohe commented Apr 21, 2021

I'm working on a oidc-op version that includes oidcendpoint which will make the oidcendpoint package vanish.
I've applied your changes to the oidc-op branch (incl_oidcendpoint) I'm working on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants