Skip to content

prevent apple clang 17 wrapping #5636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjmjohnson wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

prevent apple clang 17 wrapping #5636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Wrapping/Generators/CastXML/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,16 @@ else()
set(_castxml_hash)
set(_castxml_version 2025.09.03)
set(_castxml_git_tag v0.6.13)
# castxml 2025.09.03 currently not compatible with AppleClang 17 (XCode 26)
if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "17")
message(
FATAL_ERROR
"Apple Clang ${CMAKE_CXX_COMPILER_VERSION} is not supported. Need AppleClang < 17."
Copy link
Member

@dzenanz dzenanz Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this PR would fix #5540, in a sense that it would produce this user-friendly error message instead?

Copy link
Member Author

@hjmjohnson hjmjohnson Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only going for a user friedly error message early. I was frustrated that if I forgot to set my compilers explicitly, then 30 minutes of compilation would go by before the build failed.

)
endif()
endif()

# If 64 bit Linux build host, use the CastXML binary
if(
CMAKE_HOST_SYSTEM_NAME
Expand Down
Loading