Remove or replace vnl_sample from a few more tests
#5658
Merged
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not used anymore, after commit ca1c752 "BUG: Add fixed seed to registration tests", May 17, 2017.
github-actions
bot
added
type:Testing
dzenanz
approved these changes
Nov 25, 2025
N-Dekker
commented
Nov 25, 2025
Modules/Segmentation/SignedDistanceFunction/test/itkPCAShapeSignedDistanceFunctionGTest.cxx
Outdated
Show resolved
Hide resolved
Replaced vnl_sample_normal with `std::mt19937` and `std::normal_distribution`.
N-Dekker
force-pushed
the
Remove-vnl_sample-from-tests
branch
from
8aba6af to
fa35af3
Compare
hjmjohnson
approved these changes
Nov 26, 2025
hjmjohnson
merged commit 7597180
into
InsightSoftwareConsortium:main
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<random>in VoronoiSegmentation tests #5624