BUG: Let DataObjectError override ExceptionObject::Print
#5667
+5
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of introducing a new virtual member function, `DataObjectError::PrintSelf`. It is essential that DataObjectError overrides `ExceptionObject::Print`, because that is the member function that is called, when doing `std::cerr << error` for a DataObjectError. - Fixes issue InsightSoftwareConsortium#5666 "DataObjectError print to output stream should also print info about its DataObject"
github-actions
bot
added
type:Bug
dzenanz
approved these changes
Nov 28, 2025
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
LGTM. Thinking of how this went on for so long, I realized I never used DataObjectError. I guess most code uses itk::ExceptionObject.
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of introducing a new virtual member function,
DataObjectError::PrintSelf.It is essential that DataObjectError overrides
ExceptionObject::Print, because that is the member function that is called, when doingstd::cerr << errorfor a DataObjectError.