Skip to content

ENH: Use GTest::gtest and GTest::gtest_main targets #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hjmjohnson merged 1 commit into from
Dec 12, 2025
Merged

ENH: Use GTest::gtest and GTest::gtest_main targets #5675

hjmjohnson merged 1 commit into from
Dec 12, 2025
+5 −12

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented Dec 9, 2025 •
edited
Loading

These are the targets currently exported by CMake's FindGTest, the GTest::GTest, and GTest::Main targets were deprecated in CMake 3.20, adn removed in CMake 4.1.0.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation area:ThirdParty Issues affecting the ThirdParty module labels Dec 9, 2025
@blowekamp blowekamp force-pushed the gtest_modern_targets branch 3 times, most recently from 55ddfde to 1990ab4 Compare December 9, 2025 20:33
@blowekamp blowekamp marked this pull request as ready for review December 9, 2025 21:44
@blowekamp
ENH: Use GTest::gtest and GTest::gtest_main targets
51c24a5 
These are the targets currently exported by CMake's FindGTest.

Remove the GTest::GTest, and GTest::Main targets which deprecated in
CMake 3.20, and removed in CMake 4.1.0.
@blowekamp blowekamp force-pushed the gtest_modern_targets branch from 1990ab4 to 51c24a5 Compare December 10, 2025 16:05
thewtex
thewtex approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjmjohnson hjmjohnson merged commit d345765 into InsightSoftwareConsortium:main Dec 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

@N-Dekker N-Dekker Awaiting requested review from N-Dekker

Assignees

No one assigned

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blowekamp @thewtex @hjmjohnson @dzenanz