Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 22, 2024

lposen and others added 30 commits September 30, 2024 13:12
This commit refactors the `IterableAction` and `IterableActionContext` classes. It moves them from the `src` folder to the `ts` folder. Additionally, it removes the unused `use strict` directive and renames the `index` file. The changes aim to improve the code organization and maintainability.
Refactor IterableInbox.tsx and remove unused imports

Add comment to IterableInboxMessageCell.tsx

Add comment to IterableInboxMessageDisplay.tsx

Add comments and descriptions to IterableLogger.ts

Add a description to IterableUtil.ts

Add comment to useAppStateListener.ts

Add comment to useDeviceOrientation.tsx
Refactor IterableInbox.tsx and improve code readability
…sdk-to-use-recommended-scaffolding

[MOB-9669] update-rn-sdk-to-use-recommended-scaffolding
lposen and others added 23 commits December 12, 2024 15:57
…-rules-stricter

[MOB-10141] make lint rules stricter
…nerator

[MOB-9676] docs and doc generator
…nore

[MOB-10208] Update .npmignore to include additional default ignores and test files
…ader-for-rniterableapi

[MOB-10290] create-loader-for-rniterableapi
…tegration-testing-code

[MOB-10412] remove-integration-testing-code
…s-into-tickets

[MOB-10289] Make todos into tickets
[MOB-10430] Cleans up things not addressed in tickets
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Lines Statements Branches Functions
Coverage: 38%
37.76% (176/466) 11.86% (21/177) 32.25% (50/155)

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 67396 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

There are too many results to compare

The test coverage on the diff in this pull request is 38.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 38.0% (-17.4% change).

View more on Code Climate.

Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked through the PR list.
Can you verify MOB-9270? We are using the latest iOS18 / Android 15. Is this just due to pointing to the released versions?
I think MOB-9748 is separate since this is dealing with updating release process.

@lposen
Copy link
Contributor Author

lposen commented Jan 6, 2025

Just looked through the PR list. Can you verify MOB-9270? We are using the latest iOS18 / Android 15. Is this just due to pointing to the released versions? I think MOB-9748 is separate since this is dealing with updating release process.

You're correct re: MOB-9748.
Re: MOB-9270, I believe we were a version behind on one of them, so it was updated in the branch.

@lposen lposen merged commit 094d244 into master Jan 6, 2025
6 of 9 checks passed
@lposen lposen deleted the 2.0.0-alpha/master branch January 6, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants