Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 23, 2024

🔹 JIRA Ticket(s) if any

✏️ Description

  • Fixes unit tests
  • Adds action to publish coverage in the repo on code change

…ing-library/react-native in package.json and yarn.lock
…ish workflow, and enable additional Code Climate plugins
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

Lines Statements Branches Functions
Coverage: 36%
35.95% (174/484) 11.56% (20/173) 31.05% (50/161)

@lposen lposen requested a review from evantk91 October 24, 2024 17:59
Base automatically changed from 2.0.0-alpha/MOB-10036-delete-old-sample-app to 2.0.0-alpha/master November 27, 2024 21:43
An error occurred while trying to automatically change base from 2.0.0-alpha/MOB-10036-delete-old-sample-app to 2.0.0-alpha/master November 27, 2024 21:43
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left comment about deprecated library :)

"@react-native/eslint-config": "^0.73.1",
"@react-navigation/native": "^6.1.18",
"@release-it/conventional-changelog": "^5.0.0",
"@testing-library/jest-native": "^5.4.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked up the jest-native library and it is indicated as deprecated. Is this a concern?
https://github.com/testing-library/jest-native

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The react-native library is the correct recommended version.

@lposen lposen merged commit c9c0e15 into 2.0.0-alpha/master Nov 27, 2024
3 of 4 checks passed
@lposen lposen deleted the 2.0.0-alpha/MOB-9673-new-unit-tests branch November 27, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants