[MOB-9995] reorganize source code #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d update imports; create new hooks index file
…ectory and update imports accordingly
…pp module and update references
…troduce new enums, and update imports accordingly
…tory, consolidate type imports, and update references accordingly
…ResponseResult, move IterableAttributionInfo and IterableCommerceItem to separate files, and update imports accordingly
…le module and update references throughout the codebase
…nd IterableActionSource to separate files and update imports accordingly
…pdate imports, and introduce IterableLogLevel enum
… IterableConfig, and create IterableAuthResponse class
…terableAttributionInfo, and IterableCommerceItem; consolidate imports from enums
…e file and update imports
…ssage: update to named imports for consistency
…orts for inApp and inbox
…e exports, update paths for consistency, and enhance organization
…version retrieval
… IterableInboxCustomizations, IterableInboxImpressionRowInfo, and IterableInboxRowViewModel
…-alpha/MOB-9995-reorganize-source-code
lposen
changed the title
…com:Iterable/react-native-sdk into 2.0.0-alpha/MOB-9995-reorganize-source-code * '2.0.0-alpha/MOB-9995-reorganize-source-code' of github.com:Iterable/react-native-sdk: Add environment setup instructions to README: include example PATH configurations for rbenv, nvm, Android SDK, Java, and Node Add troubleshooting steps for Android SDK location errors in README Update Gradle and Android Gradle Plugin versions: upgrade to Gradle 8.9 and Android Gradle Plugin 8.7.2 Add Ruby version check to README: include instructions for verifying the correct Ruby version is loading Fix typo in README: add missing period to installation instruction Remove Gemfile.lock and update README with troubleshooting steps for common errors
|
…-alpha/MOB-9995-reorganize-source-code
…-alpha/MOB-9995-reorganize-source-code
…-alpha/MOB-9995-reorganize-source-code
…-alpha/MOB-9995-reorganize-source-code
evantk91
approved these changes
Dec 3, 2024
Contributor
evantk91
left a comment
evantk91
left a comment
There was a problem hiding this comment.
Looking great! Thoroughly looked through all the imports and ran the example apps.
| import IterableInboxMessageDisplay from '../IterableInboxMessageDisplay'; | ||
| import IterableInboxMessageList from '../IterableInboxMessageList'; | ||
| import { useAppStateListener, useDeviceOrientation } from '../hooks'; | ||
|
|
Contributor
There was a problem hiding this comment.
Nice use of the index file. The imports are very organized.
| import IterableInAppManager from './IterableInAppManager'; | ||
| import IterableInAppMessage from './IterableInAppMessage'; | ||
| } from './inApp'; | ||
| import { IterableLogger } from './IterableLogger'; |
Contributor
There was a problem hiding this comment.
Nice I like the reorganization
|
|
||
| static fromDict(dict: any): IterableInboxMetadata { | ||
| return new IterableInboxMetadata(dict.title, dict.subtitle, dict.icon); | ||
| } |
Contributor
There was a problem hiding this comment.
Breaking up IterableInAppClasses looks good. Checked all the associated classes are covered. Nice reorganization.
src/Iterable.ts
Outdated
|
|
||
| enum AuthResponseCallback { | ||
| enum IterableAuthResponseResult { | ||
| SUCCESS, |
Contributor
Author
There was a problem hiding this comment.
Thanks! Trying to make sure that it isn't confusing for the client when importing things from our code.
|
|
||
| if (Iterable.savedConfig.authHandler) { | ||
| let authResponseCallback: AuthResponseCallback; | ||
| let authResponseCallback: IterableAuthResponseResult; |
Contributor
There was a problem hiding this comment.
Do we want to rename variable authResponseCallback to authResponseResult to align?
Contributor
Author
There was a problem hiding this comment.
As it is internal, I don't think it is really necessary
src/enums/IterableEventName.ts
Outdated
| handleAuthFailureCalled = 'handleAuthFailureCalled', | ||
| } | ||
|
|
||
| export default IterableEventName; |
|
|
||
| // TODO: Add description | ||
| type AuthCallBack = () => void; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It's such a simple type that it's not really needed
tsconfig.json
Outdated
| "inbox/*": ["./src/inbox/*"], | ||
| "inbox": ["./src/inbox/index"], | ||
| "inApp/*": ["./src/inApp/*"], | ||
| "inApp": ["./src/inApp/index"], |
Contributor
There was a problem hiding this comment.
Not sure exactly what this change is for
| @@ -0,0 +1,3 @@ | |||
| export * from './classes'; | |||
| export * from './enums'; | |||
| export * from './hooks'; | |||
Contributor
There was a problem hiding this comment.
Nice reorganization. Didn't know you could have nested index files.
| never = 2, | ||
| } | ||
|
|
||
| export default IterableInAppTriggerType; |
Contributor
There was a problem hiding this comment.
Ah I see. Disregard the comments on this. :)
Base automatically changed from
2.0.0-alpha/MOB-10131-remove-duplicate-code
to
2.0.0-alpha/master
December 3, 2024 21:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description
Reorganizes source code for better readability
Organizes source code into
core,inAppandinboxfolders -- eventually, these should be made into packages to reduce bloat in client apps.