Add pagination for search based fetchers #13490

paudelritij · 2025-07-07T05:26:13Z

Closes #5507

This PR introduce pagination for web-search results.

Steps to test

To fetch entries from an online catalog, choose View → Web search, and the search interface will appear in the side panel.
Select the catalogs you want to search (e.g., arXiv) in the dropdown menu.
Then enter the words of your query, and press Enter, or the Search button.
The results will be displayed in the import inspection dialog.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in JabRef/user-documentation@main/en.

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java

jabref-machine · 2025-07-07T05:35:22Z

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it.

In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.

- Clone and create web* (WebImportEntriesDialog and WebImportEntriesDialogViewModel for web implementation) - Cache prev pages in case of page based fetcher

- Enhance the background fetching mechanism for page-based search entries - Fix 'Import Entries' button functionality - Fix display of total and selected items counters - Fix selection buttons behavior (unselectAll, selectAllNewEntries, selectAllEntries)

- generalized fetching of entries for all page-search-based fetcher - improved pageNumberLabel UI - update JabRef_en.properties

koppor

Much code is copied - should not happen. Can you unify? Maybe show and hide buttons? Treat fetching of non-pages as special case?

jabgui/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.java

jablib/src/main/resources/l10n/JabRef_en.properties

…favor of integrating pagination into ImportEntriesDialog.

…meters

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java

InAnYan · 2025-08-10T12:15:28Z

Thank you for working on this feature! I'm one of persons who wants it

subhramit

Hey, sorry for keeping you waiting for so long.
The maintainers were a bit busy.
I have left some more comments - once you address them, IMO should be good to merge.

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java

InAnYan

Great! It works!

Though, there is small UI problem, it shows new entry quicker than updating the "Fetching..." label. As soon as new entries are fetched, the label should be updated to "%0 of %1".

Overall, everything's good!

- Added status label to display loading messages and entry status. - Implemented bindings to enable/disable pagination buttons based on loading state and current page. - Updated next/previous page button actions to handle fetching more entries when on the last page. - Introduced initialLoadComplete property to manage the loading state more effectively.

paudelritij · 2025-08-25T05:57:17Z

Though, there is small UI problem, it shows new entry quicker than updating the "Fetching..." label. As soon as new entries are fetched, the label should be updated to "%0 of %1".

There is no UI issue, I made fetching of entries when user is on last page, since 1st page is last page initially so dialog was showing 'Fetching...' and when user lands on last page it was made to auto fetch entries and show 'Fetching...' instead of 3 of 3 which is last page.

I have enhanced the UI which will now provide comprehensive feedback to user when they are on last page and want to navigate further. PR description ss has been updated.

jablib/src/main/java/module-info.java

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java

InAnYan

Thanks for your dedication! I think after you'll address others comments, then we can merge this PR

- Refactor ImportEntriesViewModel and ImportEntriesDialog to use Optional for fetcher and query.

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java

trag-bot · 2025-08-31T12:01:42Z

@trag-bot didn't find any issues in the code! ✅✨

addressed

Add Pagination for fetchers

62ed1b5

trag-bot bot reviewed Jul 7, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java Outdated Show resolved Hide resolved

koppor added component: fetcher component: ui labels Jul 7, 2025

paudelritij added 7 commits July 18, 2025 14:59

An Attempt to define pagination for arXiv

cfb4848

- Clone and create web* (WebImportEntriesDialog and WebImportEntriesDialogViewModel for web implementation) - Cache prev pages in case of page based fetcher

Merge branch 'main' into fix-for-issue-5507

ae34392

Fix page number display state for pagination

a10adf4

Minor fixes

ee4cabb

- Enhance the background fetching mechanism for page-based search entries - Fix 'Import Entries' button functionality - Fix display of total and selected items counters - Fix selection buttons behavior (unselectAll, selectAllNewEntries, selectAllEntries)

Refactor fetchMoreEntries method

7511a6c

- generalized fetching of entries for all page-search-based fetcher - improved pageNumberLabel UI - update JabRef_en.properties

Merge branch 'main' into fix-for-issue-5507

8b454fc

Add CHANGELOG.md entry

2030c8d

paudelritij marked this pull request as ready for review July 24, 2025 15:15

paudelritij requested a review from koppor July 24, 2025 15:16

koppor mentioned this pull request Jul 28, 2025

Better code clone detection tsantalis/RefactoringMiner#962

Closed

koppor previously requested changes Jul 28, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.java Outdated Show resolved Hide resolved

jablib/src/main/resources/l10n/JabRef_en.properties Outdated Show resolved Hide resolved

jablib/src/main/resources/l10n/JabRef_en.properties Outdated Show resolved Hide resolved

paudelritij added 3 commits August 3, 2025 01:30

Remove WebImportEntriesDialog, its ViewModel, and associated FXML in …

3e8f567

…favor of integrating pagination into ImportEntriesDialog.

Merge branch 'main' into fix-for-issue-5507

1a9d5a4

Refactor ImportEntriesDialog instantiation to remove unnecessary para…

539d54d

…meters

paudelritij requested a review from koppor August 4, 2025 00:15

subhramit reviewed Aug 9, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java Outdated Show resolved Hide resolved

InAnYan requested changes Aug 10, 2025

View reviewed changes

paudelritij added 3 commits August 16, 2025 13:15

Merge branch 'main' into fix-for-issue-5507

e8a14d8

Minor fixes

f41f640

Minor fix

2506c6e

calixtus requested a review from InAnYan August 22, 2025 08:45

Merge branch 'main' into fix-for-issue-5507

f401572

subhramit requested changes Aug 22, 2025

View reviewed changes

InAnYan requested changes Aug 22, 2025

View reviewed changes

paudelritij added 3 commits August 25, 2025 01:39

Minor fix

5c2506c

Update JabRef_en.properties

51b5f6d

paudelritij requested a review from InAnYan August 25, 2025 06:02

paudelritij mentioned this pull request Aug 25, 2025

Update import dialog (pagination, choose group)and update ss JabRef/user-documentation#585

Open

Siedlerchr reviewed Aug 25, 2025

View reviewed changes

jablib/src/main/java/module-info.java Show resolved Hide resolved

calixtus reviewed Aug 25, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java Show resolved Hide resolved

InAnYan previously approved these changes Aug 25, 2025

View reviewed changes

Apply boy scout principle

d7fe212

- Refactor ImportEntriesViewModel and ImportEntriesDialog to use Optional for fetcher and query.

paudelritij dismissed InAnYan’s stale review via d7fe212 August 30, 2025 16:54

Merge branch 'main' into fix-for-issue-5507

ae6975c

trag-bot bot reviewed Aug 30, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java Show resolved Hide resolved

paudelritij added 2 commits August 31, 2025 08:55

Merge branch 'main' into fix-for-issue-5507

4a6eff6

Merge branch 'main' into fix-for-issue-5507

562c7b0

subhramit approved these changes Aug 31, 2025

View reviewed changes

subhramit added this pull request to the merge queue Aug 31, 2025

koppor mentioned this pull request Aug 31, 2025

[JBang] Fix files matched #13797

Merged

1 task

Merged via the queue into JabRef:main with commit c06435a Aug 31, 2025
3 checks passed

github-actions bot mentioned this pull request Aug 31, 2025

UI: Paging support for fetchers #5507

Closed

3 tasks

Uh oh!

Add pagination for search based fetchers #13490

Add pagination for search based fetchers #13490

Uh oh!

Conversation

paudelritij commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

Uh oh!

jabref-machine commented Jul 7, 2025

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

InAnYan commented Aug 10, 2025

Uh oh!

subhramit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

InAnYan left a comment

Choose a reason for hiding this comment

Uh oh!

paudelritij commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

InAnYan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trag-bot bot commented Aug 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

paudelritij commented Jul 7, 2025 •

edited

Loading