Skip to content

Conversation

@Yubo-Cao
Copy link
Collaborator

@Yubo-Cao Yubo-Cao commented Aug 29, 2025

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/782

image

Steps to test

Open Help > View Event Log

image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@subhramit
Copy link
Member

Can you link the specific sub-task @Yubo-Cao
Currently, the entire meta-issue is linked that will be closed on merging this otherwise

@subhramit
Copy link
Member

subhramit commented Aug 29, 2025

Thoughts: This will definitely help in debugging
However, should a user be able to see these details is something that we should discuss.
E.g. Unsupported JavaFX configuration
@JabRef/developers

@InAnYan
Copy link
Member

InAnYan commented Aug 29, 2025

So in previous versions users could not see "Unsupported JavaFX configuration"?

I would leave everything.

Though.. maybe we can add a combobox for filtering (>=) log levels?

@subhramit subhramit requested a review from a team August 29, 2025 10:07
@Yubo-Cao
Copy link
Collaborator Author

Thoughts: This will definitely help in debugging However, should a user be able to see these details is something that we should discuss. E.g. Unsupported JavaFX configuration @JabRef/developers

I didn't change the error console logic at all. I figured perhaps ... I messed up my JavaFX environment? I probably should have linked this issue instead: https://github.com/JabRef/jabref-issue-melting-pot/issues/782

@subhramit
Copy link
Member

I didn't change the error console logic at all.

Ah, my confusion stemmed from not opening the event log since a long time, sorry

subhramit
subhramit previously approved these changes Aug 30, 2025
Copy link
Member

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check once if the javafx configuration thing appears on main as well

@Siedlerchr
Copy link
Member

The unsupported javafx config comes from merging modules together. This is a known issue.

* upstream/main:
  Fix/theme manager (JabRef#13764)
  Hotfix: Remove obsolete language keys
Siedlerchr
Siedlerchr previously approved these changes Aug 30, 2025
@Siedlerchr Siedlerchr dismissed stale reviews from subhramit and themself via 0ce4c88 August 30, 2025 11:11
@Siedlerchr Siedlerchr enabled auto-merge August 30, 2025 11:12
@Siedlerchr Siedlerchr disabled auto-merge August 30, 2025 11:12
@jabref-machine
Copy link
Collaborator

Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes.

When the pull request is getting integrated into main, all commits will be squashed anyway. Thus, your individual commit history will not be visible in main.

In future, please avoid that. For now, you can continue working.

@calixtus
Copy link
Member

You could add a link to the issue tracker, if you say that an issue could be reported in the intro text. But how ever, I think the info text belongs into the documentation and not into the ui.

@trag-bot
Copy link

trag-bot bot commented Aug 30, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 30, 2025
Merged via the queue into JabRef:main with commit 225bba6 Aug 30, 2025
1 check passed
@subhramit
Copy link
Member

We forgot to add a changelog entry for this

@Yubo-Cao
Copy link
Collaborator Author

We forgot to add a changelog entry for this

I conveniently updated the CHANEGLOG at another open PR that would get this fixed after merged... #13791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants