Feat: Add definition links for Markdown Files #14032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Related work on finding the start of the citation key: org.jabref.logic.texparser.DefaultLatexParser#CITE_PATTERN. However, that one is easy, because it just looks for |
…en the article in the bibfile
koppor
reviewed
Oct 16, 2025
|
|
||
| public abstract class DefinitionProvider { | ||
|
|
||
| private static final Pattern CITATION_KEY_PATTERN = Pattern.compile("@[a-z0-9_\\-.+:]+", Pattern.CASE_INSENSITIVE); |
Member
There was a problem hiding this comment.
Just a note: PanDoc seems "also" be straight-forward: https://github.com/jgm/pandoc/blob/eb9bfb6b962efda02d33f548adc09939c5c005df/src/Text/Pandoc/Readers/Markdown.hs#L1534
koppor
approved these changes
Oct 16, 2025
Collaborator
|
Your pull request needs to link an issue correctly. To ease organizational workflows, please link this pull request to the issue by including a supported keyword in the pull request's description as per syntax described in GitHub's documentation. Examples
|
bblhd
pushed a commit
to bblhd/jabref
that referenced
this pull request
Oct 16, 2025
* Add definition links for Markdown * add ability to jumpToEntry from LSP and when running in standalone open the article in the bibfile * fix jbang * fix jbang again * fix jbang again... * reformat * reformat again * rename Logging Class * fix modernizer * switch to jspecify annotation * remove workspace capabilities * remove unused messagehandler * remove unused import * refactor * refactor: enhance citation key pattern matching and validation * sort alphabetically * docs: add clarification comment regarding LSP position handling --------- Co-authored-by: Christoph <[email protected]>
hisunll
added a commit
to hisunll/jabref
that referenced
this pull request
Oct 22, 2025
This reverts commit a985422.
palukku
changed the title
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
* Add definition links for Markdown * add ability to jumpToEntry from LSP and when running in standalone open the article in the bibfile * fix jbang * fix jbang again * fix jbang again... * reformat * reformat again * rename Logging Class * fix modernizer * switch to jspecify annotation * remove workspace capabilities * remove unused messagehandler * remove unused import * refactor * refactor: enhance citation key pattern matching and validation * sort alphabetically * docs: add clarification comment regarding LSP position handling --------- Co-authored-by: Christoph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes palukku#57 partially
Added the ability to ctrl + click on an
[@citationKey]in markdown files and it jumps to the entry in the GUI (if running in gui mode) else it jumps to the content of the entry in the bib file also ctrl + hover shows a preview of the entry then.Also works if the same citationkey is defined in multiple bib files in the workspace.
Steps to test
Start the Language Server and an VSCode instance with the extension enabled.
Have a .bib file with entries in it.
Cite one entry in an markdown file and ctrl + click on it.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)