Skip to content

Rename packages in jabkit to start with org.jabref.toolkit to avoid split packages between jabkit and jabgui (#14052). #14271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koppor merged 6 commits into from
Nov 9, 2025
Merged

Rename packages in jabkit to start with org.jabref.toolkit to avoid split packages between jabkit and jabgui (#14052). #14271

koppor merged 6 commits into from
Nov 9, 2025

Conversation

@Stewori
Copy link
Contributor

@Stewori Stewori commented Nov 9, 2025 •
edited by koppor
Loading

Closes #14052

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor
Copy link
Member

koppor commented Nov 9, 2025

No need for CHANGELOG.md entry, because we have user (GUI, CLI) facing issues here - not code issues.

Future may change this - but maybe we need separate CHANGELOG.md files then (jablib, jabkit, and jabgui AKA JabRef)

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Nov 9, 2025
@koppor
Copy link
Member

koppor commented Nov 9, 2025

Refcatoring Miner summary:

grafik

@koppor koppor mentioned this pull request Nov 9, 2025
Closed
@koppor
Copy link
Member

koppor commented Nov 9, 2025

First, #14244 needs to go in, then the introduced class be moved to the new structure (here) - and then this can go.

@koppor koppor merged commit 99191e1 into JabRef:main Nov 9, 2025
50 of 54 checks passed
@github-actions github-actions bot mentioned this pull request Nov 9, 2025
Closed
@Stewori Stewori deleted the rename_jabkit_pck branch November 10, 2025 12:55
Siedlerchr added a commit that referenced this pull request Nov 10, 2025
@Siedlerchr
Merge branch 'main' into jackson3
bc7b308 
* main:
  Fix calling JBang command (#14282)
  .jbang scripts should not be included inside themselves (#14278)
  Fix typos (#14277)
  Refactor importDatabase for better readability (#14274)
  fix jbang (#14276)
  Feat: Add definition links for TeX Files (#14260)
  Update preventing module commits (#14273)
  Fix JabKitLuancher
  Rename packages in jabkit to start with org.jabref.toolkit to avoid split packages between jabkit and jabgui (#14052). (#14271)
  Add doi-to-bibtex to examples and JabKit (#14244)
@koppor koppor mentioned this pull request Nov 16, 2025
Merged
2 tasks
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@Stewori @koppor @merlinymy
Rename packages in jabkit to start with org.jabref.toolkit to avoid s…
4bbfc57 
…plit packages between jabkit and jabgui (JabRef#14052). (JabRef#14271)

Co-authored-by: Oliver Kopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package and Class name collision accross modules

2 participants

@Stewori @koppor