CMP-8068 Fix crash in getSystemEnvironment on headless desktop
#5471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash in
getSystemEnvironmenton desktop when running in a headless environment (such as most CI runners) by providing a default density qualifier. In the future that might be something that's nice to make configurable, but since both our use case and the linked issue encountered it when callinggetStringI didn't worry about it too hard.Fixes CMP-8068
Testing
Made a local build and used it to run some tests in another project that were failing on calls to
getStringRelease Notes
Section - Subsection
getSystemEnvironmenton headless desktop