[platform] Refactor: Replace repeated regex string literals with compiled Patterns part 1. #3299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled Patterns part 1.
Member
|
I am not sure whether we should merge this, there are cases where this change could negatively affect the performance. Statics are initialized when the class gets instantiated so it might be the case that we compile a regex, and then never use it. |
| public void appendTo(@NotNull StringBuilder builder) { | ||
| builder.append(StringUtil.escapeXmlEntities(myContent).replaceAll("\n", "<br/>")); | ||
| builder.append( | ||
| NEWLINE_PATTERN.matcher(StringUtil.escapeXmlEntities(myContent)) |
Member
There was a problem hiding this comment.
Probably, just replacing this call with replace would be better. Starting from JDK 9 the replace method doesn't use Regex anymore and should be faster for regular string literal replacements. It's not a clear case though, this module has its language level set to 8, so for JDK 8 clients of this code, it will run slower than the pre-compiled variant.
Contributor
Author
|
@BartvHelvert Ok, closing then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 from #3272