base: don't escape "&" anymore

Author: JohannesKaufmann

plugin/base/base.go

@@ -103,7 +103,10 @@ var characterEntityReplacer = strings.NewReplacer(
 	// care about fewer characters
 	"<", "&lt;",
 	">", "&gt;",
-	"&", "&amp;",
+
+	// Note: We are not escaping "&" as "&amp;" anymore.
+	// In most cases the "&" is completely fine.
+	// https://github.com/JohannesKaufmann/html-to-markdown/issues/178
 )
 
 func (b *base) handleTextTransform(ctx converter.Context, content string) string {

plugin/commonmark/testdata/GoldenFiles/link.out.md

@@ -266,11 +266,11 @@ before[**already bold**](/)after
 
 before**[middle](/)**after
 
-before**[*inside bold & italic*](/)**after
+before**[*inside bold & italic*](/)**after
 
-before***[inside bold & italic](/)a*b**after
+before***[inside bold & italic](/)a*b**after
 
-before**[inside bold & italic](/)**after
+before**[inside bold & italic](/)**after
 
 before**a*b[c](/)d*e**after
 

plugin/commonmark/testdata/GoldenFiles/metadata.out.md

@@ -10,9 +10,9 @@
 
 2 > 1  
 1 < 2  
-A & B  
-A & B  
-ö
+A & B  
+A & B  
+ö
 
 \*not emphasized*  
 <br/> not a tag  
@@ -22,7 +22,7 @@ A & B
 \* not a list  
 \# not a heading  
 \[foo]: /url "not a reference"  
-ö not a character entity
+ö not a character entity
 
 Start Line