Skip to content

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Oct 7, 2025

Before:

Expression: save("test.not_installed", nothing)
    Expected: CapturedException
      Thrown: MethodError
      MethodError: no method matching 
stacktrace(::Vector{Base.StackTraces.StackFrame})
      The function `stacktrace` exists, but no method is defined for 
this combination of argument types.
      Closest candidates are:
        stacktrace(::Bool)
         @ Base stacktraces.jl:206
        stacktrace()
         @ Base stacktraces.jl:206
        stacktrace(::Vector{<:Union{Ptr{Nothing}, Base.InterpreterIP}},
 ::Bool)
         @ Base stacktraces.jl:193
        ...
      Stacktrace:
        [1] CapturedException(ex::ArgumentError, 
bt_raw::Vector{Base.StackTraces.StackFrame})
          @ Base ./task.jl:17
        [2] handle_error(e::ArgumentError, q::Base.PkgId, 
bt::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}})
          @ FileIO 
~/PkgEval/problemos/FileIO.jl/src/error_handling.jl:71
        [3] handle_exceptions(exceptions::Vector{Tuple{Any, 
Union{Base.PkgId, Module}, Vector}}, action::String)
          @ FileIO 
~/PkgEval/problemos/FileIO.jl/src/error_handling.jl:66
        [4] action(call::Symbol, libraries::Vector{Union{Base.PkgId, 
Module}}, file::Formatted, args::Nothing; options::@Kwargs{})
          @ FileIO ~/PkgEval/problemos/FileIO.jl/src/loadsave.jl:228
        [5] action
          @ ~/PkgEval/problemos/FileIO.jl/src/loadsave.jl:196 [inlined]
        [6] action
          @ ~/PkgEval/problemos/FileIO.jl/src/loadsave.jl:185 [inlined]
        [7] save(file::String, args::Nothing; options::@Kwargs{})
          @ FileIO ~/PkgEval/problemos/FileIO.jl/src/loadsave.jl:129
        [8] save(file::String, args::Nothing)
          @ FileIO ~/PkgEval/problemos/FileIO.jl/src/loadsave.jl:125

Not sure how the trim! functionality should be restored. I'll open an issue about that.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (83af3dd) to head (fabe01d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   91.40%   91.44%   +0.03%     
==========================================
  Files          11       11              
  Lines         710      713       +3     
==========================================
+ Hits          649      652       +3     
  Misses         61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KristofferC KristofferC enabled auto-merge (squash) October 7, 2025 12:24
@KristofferC KristofferC disabled auto-merge October 7, 2025 12:24
@KristofferC KristofferC merged commit aecfecd into master Oct 7, 2025
17 checks passed
@KristofferC KristofferC deleted the kc/stacktrace branch October 7, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants