Skip to content

Conversation

@IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 8, 2023

Related to #392

Todo:

  • Add expected values tests for example videos
  • Add generated video tests with more fps values

cc. @AbelHo

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.82%. Comparing base (1e0dca4) to head (acd7a18).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   77.70%   77.82%   +0.11%     
==========================================
  Files          10       10              
  Lines        1310     1308       -2     
==========================================
  Hits         1018     1018              
+ Misses        292      290       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AbelHo
Copy link
Contributor

AbelHo commented Feb 9, 2023

results from this 7f2c717 :

julia> VideoIO.framerate.(VideoIO.openvideo.(fnames))
5-element Vector{Rational{Int32}}:
 1//90000
 1//12800
 1//15360
 1//1000
 1//25000

julia> map(fnames) do x
               vid=VideoIO.openvideo(x); read(vid); VideoIO.framerate(vid)
       end
5-element Vector{Rational{Int32}}:
 1//90000
 1//12800
 1//15360
 1//1000
 1//25000

julia> get_fps.(fnames)
5-element Vector{Rational{Int64}}:
 30//1
 25//1
 30//1
 25//1
 25//1

@IanButterworth
Copy link
Member Author

@AbelHo @f3fora would you mind reviewing this. I can't see why the tests are failing

@IanButterworth
Copy link
Member Author

Bump @AbelHo (I saw the thumbs up. Thanks!)

@IanButterworth
Copy link
Member Author

Bump. Help would be appreciated 🙏

@IanButterworth IanButterworth merged commit aadd066 into master Oct 25, 2025
18 checks passed
@IanButterworth IanButterworth deleted the ib/framerate_test branch October 25, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants