Skip to content

ci: update ci build matrix #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inkydragon wants to merge 9 commits into
base: master
Choose a base branch
from
Open

ci: update ci build matrix #316

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e5600aa
ci: use `macos-15-intel`
inkydragon Dec 12, 2025
097574e
ci: run ci with `ubuntu-latest-arm`
inkydragon Dec 12, 2025
f1ca5b7
ci: test with `lts` and `1`
inkydragon Dec 12, 2025
48a549a
ci: update `julia-actions/cache` permissions
inkydragon Dec 12, 2025
02db748
ci: use `julia-actions/julia-buildpkg`
inkydragon Dec 12, 2025
17db74c
ci: add concurrency rules
inkydragon Dec 12, 2025
b10b430
Apply suggestions from code review
inkydragon Dec 12, 2025
fa51559
ci: test with julia nightly
inkydragon Dec 12, 2025
d46b83e
ci: remove nightly ci
inkydragon Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions .github/workflows/UnitTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,38 @@ on:
pull_request:
workflow_dispatch:

concurrency:
# Skip intermediate builds: always.
# Cancel intermediate builds: only if it is a pull request build.
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}

jobs:
test:
name: Julia v${{ matrix.julia-version }}-${{ matrix.julia-arch }} - ${{ matrix.os }}
runs-on: ${{ matrix.os }}
permissions: # needed to allow julia-actions/cache to proactively delete old caches that it has created
actions: write
contents: read
strategy:
fail-fast: false
matrix:
julia-version: ['1.6', '1']
os: [ubuntu-latest, windows-latest, macos-13]
julia-version: ['lts', '1']
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of Julia '1.0' from the test matrix is inconsistent with the package's compatibility declaration in Project.toml, which specifies 'julia = "1"' (meaning Julia 1.0+). The previous UnitTestArm.yml workflow tested Julia 1.0. If the package still claims to support Julia 1.0, it should be tested in CI. If Julia 1.0 support is being dropped, the Project.toml compat entry should be updated accordingly.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'nightly' Julia version has been removed from the test matrix. While this simplifies CI, testing against nightly builds can help catch compatibility issues early before new Julia versions are released. Consider whether removing nightly testing is intentional and aligns with the project's maintenance goals.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The julia-version has been changed from '1.6' to 'lts'. While 'lts' is a valid specifier that should resolve to the current LTS version, note that this is a semantic change. The 'lts' specifier will automatically update to newer LTS versions when they are released, whereas '1.6' was pinned. This could introduce unexpected behavior changes in CI if a new LTS version is released. Consider whether this automatic updating behavior is desired.

Copilot uses AI. Check for mistakes.
os: [ubuntu-latest, windows-latest, macos-15-intel]
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner name 'macos-15-intel' does not appear to be a valid GitHub-hosted runner. As of macOS 15, GitHub-hosted runners use ARM64 (Apple Silicon) architecture. For Intel-based macOS runners, you should use 'macos-13' which is the last Intel-based macOS runner provided by GitHub. If you need Intel testing on macOS, consider using 'macos-13', or if you want the latest macOS on ARM, use 'macos-latest' or 'macos-15'.

Suggested change
os: [ubuntu-latest, windows-latest, macos-15-intel]
os: [ubuntu-latest, windows-latest, macos-13]

Copilot uses AI. Check for mistakes.
julia-arch: [x64]
include:
- os: ubuntu-latest # only test one 32-bit job
julia-version: '1'
julia-arch: x86
- os: macos-latest
- os: ubuntu-24.04-arm
julia-version: 'lts'
julia-arch: aarch64
- os: ubuntu-24.04-arm
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner name 'ubuntu-24.04-arm' does not appear to be a standard GitHub-hosted runner. GitHub does not currently provide ARM-based Ubuntu runners as standard hosted runners. If ARM testing on Ubuntu is required, you would typically need to use self-hosted runners or alternative solutions. Consider using 'ubuntu-latest' with emulation (via setup-julia's arch parameter), or set up self-hosted ARM runners. If this is intended to be a self-hosted runner, ensure it's properly configured in your repository settings.

Suggested change
- os: ubuntu-24.04-arm
julia-version: 'lts'
julia-arch: aarch64
- os: ubuntu-24.04-arm
- os: ubuntu-latest
julia-version: 'lts'
julia-arch: aarch64
- os: ubuntu-latest

Copilot uses AI. Check for mistakes.
julia-version: '1'
julia-arch: aarch64
- os: macos-latest
julia-version: 'lts'
julia-arch: aarch64
- os: macos-latest
julia-version: '1'
julia-arch: aarch64
Expand All @@ -36,11 +52,9 @@ jobs:
with:
version: ${{ matrix.julia-version }}
arch: ${{ matrix.julia-arch }}
- name: Cache artifacts
uses: julia-actions/cache@v2
- name: "Unit Test"
uses: julia-actions/julia-runtest@v1

- uses: julia-actions/cache@v2
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v5
with:
Expand Down
76 changes: 0 additions & 76 deletions .github/workflows/UnitTestArm.yml
View file
Open in desktop

This file was deleted.

Loading