Skip to content

Conversation

@HIllya51
Copy link
Contributor

On cmake-4.1.0, when openlibm is included as a subdirectory, it causes an error:
Setting CMAKE_PROJECT_VERSION can also fix this issue, but I don't really prefer doing so.

CMake Error at openlibm/CMakeLists.txt:569 (string):
  string sub-command REPLACE requires at least four arguments.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.09%. Comparing base (c984c27) to head (7cfd051).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files         233      233           
  Lines        6139     6139           
  Branches     1607     1607           
=======================================
  Hits         4426     4426           
  Misses       1420     1420           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@inkydragon inkydragon merged commit 2fba53e into JuliaMath:master Aug 15, 2025
20 checks passed
ammarkaskar added a commit to ammarkaskar/openlibm that referenced this pull request Oct 10, 2025
cmake: Fix cmake error for 4.x (JuliaMath#333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants