-
Notifications
You must be signed in to change notification settings - Fork 646
Update FFMPEG to 6.1.1 #8090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FFMPEG to 6.1.1 #8090
Conversation
Yggdrasil/K/Kokkos/build_tarballs.jl Lines 13 to 14 in 718c7c8
Yggdrasil/K/Kokkos/build_tarballs.jl Lines 21 to 28 in 718c7c8
|
|
Still throws an error around https://buildkite.com/julialang/yggdrasil/builds/8409#018dae14-f188-440b-a2bf-b486d91ab22c/6-1702 I think I will just give up on this PR at this point and wait for a fix from FFmpeg |
Co-authored-by: Mosè Giordano <[email protected]>
F/FFMPEG/FFMPEG/build_tarballs.jl
Outdated
| HostBuildDependency("YASM_jll"), | ||
| BuildDependency("nv_codec_headers_jll"), | ||
| Dependency("libass_jll"; compat="0.15.1"), | ||
| Dependency("libass_jll"; compat = "0.15.1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove all the whitespace changes? It makes review needlessly more complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Sorry about that, forgot to deactivate format on save
|
We get Error building |
|
Only partially true, the problem is that the package manager is giving you an awfully old version of FFMPEG.jl |
* Update version of FFMPEG * allow ffplay on mac/aarch64 * Compat macos < 10.13 * Update F/FFMPEG/FFMPEG/build_tarballs.jl Co-authored-by: Mosè Giordano <[email protected]> * Revert formatting * Restore fix --------- Co-authored-by: Mosè Giordano <[email protected]>
libresampleis deprecated and was therefore removed.CUDA_ARGSwas set butffnvcodec(I could not find any jll except for https://github.com/JuliaPackaging/Yggdrasil/blob/master/N/nv_codec_headers/build_tarballs.jl ?) is not provided, resulting in an error when trying to compile it.There seems to be an error on MacOS, mentioned here and indicate that MacOS > 10.13 is needed?