Skip to content

Conversation

@theogf
Copy link
Contributor

@theogf theogf commented Feb 11, 2024

There seems to be an error on MacOS, mentioned here and indicate that MacOS > 10.13 is needed?

@theogf theogf changed the title Update version of FFMPEG Update FFMPEG to 6.1.1 Feb 11, 2024
@giordano
Copy link
Member

There seems to be an error on MacOS, mentioned here and indicate that MacOS > 10.13 is needed?

ArchiveSource("https://github.com/phracker/MacOSX-SDKs/releases/download/10.15/MacOSX10.13.sdk.tar.xz",
"a3a077385205039a7c6f9e2c98ecdf2a720b2a819da715e03e0630c75782c1e4"),
if [[ "${target}" == x86_64-apple-darwin* ]]; then
export MACOSX_DEPLOYMENT_TARGET=10.13
pushd ${WORKSPACE}/srcdir/MacOSX10.*.sdk
rm -rf /opt/${target}/${target}/sys-root/System
cp -a usr/* "/opt/${target}/${target}/sys-root/usr/"
cp -a System "/opt/${target}/${target}/sys-root/"
popd
fi

@theogf
Copy link
Contributor Author

theogf commented Feb 15, 2024

Still throws an error around https://buildkite.com/julialang/yggdrasil/builds/8409#018dae14-f188-440b-a2bf-b486d91ab22c/6-1702

I think I will just give up on this PR at this point and wait for a fix from FFmpeg

@theogf theogf closed this Feb 15, 2024
@theogf theogf reopened this Feb 15, 2024
HostBuildDependency("YASM_jll"),
BuildDependency("nv_codec_headers_jll"),
Dependency("libass_jll"; compat="0.15.1"),
Dependency("libass_jll"; compat = "0.15.1"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove all the whitespace changes? It makes review needlessly more complicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Sorry about that, forgot to deactivate format on save

@giordano giordano merged commit e5f1d2b into JuliaPackaging:master Feb 15, 2024
@JoshuaLampert
Copy link
Contributor

We get Error building FFMPEG errors, which is probably related to this change?

@giordano
Copy link
Member

Only partially true, the problem is that the package manager is giving you an awfully old version of FFMPEG.jl

@theogf theogf mentioned this pull request Feb 16, 2024
@giordano
Copy link
Member

@theogf would you mind following up this PR in FFMPEG.jl to allow major version 6?

@theogf
Copy link
Contributor Author

theogf commented Feb 16, 2024

JuliaIO/FFMPEG.jl#59

@theogf theogf deleted the tgf/update-ffmpeg branch February 16, 2024 11:19
grasph pushed a commit to Moelf/Yggdrasil that referenced this pull request Jul 1, 2024
* Update version of FFMPEG

* allow ffplay on mac/aarch64

* Compat macos < 10.13

* Update F/FFMPEG/FFMPEG/build_tarballs.jl

Co-authored-by: Mosè Giordano <[email protected]>

* Revert formatting

* Restore fix

---------

Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants