Skip to content

Conversation

@nHackel
Copy link
Contributor

@nHackel nHackel commented Jan 25, 2025

I recently encountered a system where the USER environment variable got set to "domain/user". Such a name then gets interpreted as a filepath which breaks the system_uuid_fallback logic.

As a workaround this PR hashes the variable before using it in the filepath creation. Same user names should still result in the same hash values

@nHackel
Copy link
Contributor Author

nHackel commented Jan 25, 2025

Ah actually the docs mention that the hash may change when a new process is started. I'm not entirely sure if that is an issue here, because the workers should be started before Dagger is loaded according to the docs. I also wasn't able to locally produce different hashes for the same value

@jpsamaroo jpsamaroo merged commit a047265 into JuliaParallel:master Feb 1, 2025
7 of 11 checks passed
@jpsamaroo
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants