Skip to content

submission: Reset sch_accessible for dependencies #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

submission: Reset sch_accessible for dependencies #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/submission.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,15 @@ const UID_TO_TID_CACHE = TaskLocalValue{ReusableCache{Dict{UInt64,Int},Nothing}}
id_map[uid] = thunk.id
end

# Reset sch_accessible for all syncdeps
if options.syncdeps !== nothing
for dep_weak in options.syncdeps
dep = unwrap_weak_checked(dep_weak)
@assert dep.eager_accessible "GC bug: lost eager reference to syncdep"
dep.sch_accessible = true
end
end

# Tell the scheduler that it has new tasks to schedule
if reschedule
put!(state.chan, Sch.RescheduleSignal())
Expand Down