[docs] Makie.jl #183
Open
[docs] Makie.jl #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 21 21
Lines 1292 1292
=======================================
Hits 1281 1281
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MilesCranmer
reviewed
Aug 6, 2025
| v0 = 250m/s | ||
| θ = deg2rad(60) | ||
| g = 9.81m/s^2 | ||
| nothing # hide |
Member
There was a problem hiding this comment.
Can you use ; instead of a new line with this
Contributor
Author
There was a problem hiding this comment.
Oh right, it got buried in the previous PR, but I think I was running into this when trying to do that. It's been a while though, so I'll go back and try it again
Contributor
Author
There was a problem hiding this comment.
hmm, yea, still looks like no dice with @example blocks + semicolon suppression:
```@example projectile
# Can explicitly import units:
using DynamicQuantities: km, m, s, min
y0 = 10km
v0 = 250m/s
θ = deg2rad(60)
g = 9.81m/s^2;
```
It looks like this may be a design decision
On the flip side, we could use a @repl block if you like and output all the things equally:
```@repl projectile
# Can explicitly import units:
using DynamicQuantities: km, m, s, min
y0 = 10km
v0 = 250m/s
θ = deg2rad(60)
g = 9.81m/s^2
```
For completeness, the semicolon also works here, but it's probably not what we want in this case:
```@repl projectile
# Can explicitly import units:
using DynamicQuantities: km, m, s, min
y0 = 10km
v0 = 250m/s
θ = deg2rad(60)
g = 9.81m/s^2;
```
Contributor
Author
There was a problem hiding this comment.
Hi @MilesCranmer, just bumping this last remaining open thread
Contributor
Author
|
DQ support is now in Makie v0.24.7! Will mark this PR as ready for review once things are green Some other really cool updates in Makie + units land looks to be in the works too: MakieOrg/Makie.jl#5323 I'm def looking forward to having automatic units in label support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents plotting capabilities with Makie.jl
Depends on:
Based on: #165