Skip to content

Conversation

@icweaver
Copy link
Contributor

@icweaver icweaver commented Aug 30, 2025

Continued from #178

Closes #166

Reason for new PR: Pick up base codecov report after move to JuliaPhysics

Update: nvm, this doesn't address the underlying issue with codecov

@github-actions
Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
main fa4510a... main / fa4510a...
Quantity/creation/Quantity(x) 3.1 ± 0.01 ns 2.79 ± 0.001 ns 1.11 ± 0.0036
Quantity/creation/Quantity(x, length=y) 3.42 ± 0.01 ns 3.43 ± 0.01 ns 0.997 ± 0.0041
Quantity/with_numbers/*real 3.1 ± 0.01 ns 3.41 ± 0.01 ns 0.911 ± 0.004
Quantity/with_numbers/^int 8.68 ± 1.9 ns 8.98 ± 2.2 ns 0.966 ± 0.31
Quantity/with_numbers/^int * real 9.29 ± 2.2 ns 9.29 ± 2.2 ns 1 ± 0.33
Quantity/with_quantity/+y 4.35 ± 0.009 ns 4.04 ± 0.001 ns 1.08 ± 0.0022
Quantity/with_quantity//y 3.11 ± 0.001 ns 3.11 ± 0.001 ns 1 ± 0.00046
Quantity/with_self/dimension 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1 ± 0.0046
Quantity/with_self/inv 3.11 ± 0.001 ns 3.41 ± 0.01 ns 0.912 ± 0.0027
Quantity/with_self/ustrip 2.79 ± 0.01 ns 3.71 ± 0.92 ns 0.754 ± 0.19
QuantityArray/broadcasting/multi_array_of_quantities 0.0903 ± 0.00062 ms 0.0905 ± 0.00083 ms 0.997 ± 0.011
QuantityArray/broadcasting/multi_normal_array 0.0528 ± 0.00026 ms 0.0498 ± 0.00022 ms 1.06 ± 0.007
QuantityArray/broadcasting/multi_quantity_array 0.0622 ± 0.0092 ms 0.0531 ± 0.0062 ms 1.17 ± 0.22
QuantityArray/broadcasting/x^2_array_of_quantities 12.6 ± 1.6 μs 13.4 ± 1.2 μs 0.94 ± 0.14
QuantityArray/broadcasting/x^2_normal_array 2.04 ± 1.1 μs 2.09 ± 0.92 μs 0.976 ± 0.68
QuantityArray/broadcasting/x^2_quantity_array 3.46 ± 0.13 μs 6.5 ± 0.07 μs 0.532 ± 0.021
QuantityArray/broadcasting/x^4_array_of_quantities 0.0843 ± 0.00093 ms 0.0875 ± 0.00075 ms 0.964 ± 0.013
QuantityArray/broadcasting/x^4_normal_array 0.0497 ± 0.00015 ms 0.0497 ± 0.00012 ms 1 ± 0.0039
QuantityArray/broadcasting/x^4_quantity_array 0.0529 ± 0.00046 ms 0.0498 ± 0.00015 ms 1.06 ± 0.0098
time_to_load 0.198 ± 0.0016 s 0.21 ± 0.00081 s 0.942 ± 0.0085
Memory benchmarks
main fa4510a... main / fa4510a...
Quantity/creation/Quantity(x) 0 allocs: 0 B 0 allocs: 0 B
Quantity/creation/Quantity(x, length=y) 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/*real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int * real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity/+y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity//y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/dimension 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/inv 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/ustrip 0 allocs: 0 B 0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/multi_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/multi_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^2_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^2_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^2_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^4_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^4_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^4_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@github-actions
Copy link
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main fa4510a... main / fa4510a...
Quantity/creation/Quantity(x) 3.11 ± 0.01 ns 3.41 ± 0.01 ns 0.912 ± 0.004
Quantity/creation/Quantity(x, length=y) 3.11 ± 0.01 ns 3.11 ± 0.01 ns 1 ± 0.0046
Quantity/with_numbers/*real 3.11 ± 0.001 ns 3.11 ± 0.01 ns 1 ± 0.0032
Quantity/with_numbers/^int 8.67 ± 2.5 ns 8.05 ± 2.2 ns 1.08 ± 0.42
Quantity/with_numbers/^int * real 8.37 ± 2.2 ns 8.67 ± 2.5 ns 0.965 ± 0.37
Quantity/with_quantity/+y 4.04 ± 0.01 ns 4.04 ± 0.01 ns 1 ± 0.0035
Quantity/with_quantity//y 3.42 ± 0.011 ns 3.41 ± 0.01 ns 1 ± 0.0044
Quantity/with_self/dimension 3.1 ± 0.01 ns 3.11 ± 0.01 ns 0.997 ± 0.0045
Quantity/with_self/inv 3.41 ± 0.01 ns 3.11 ± 0.01 ns 1.1 ± 0.0048
Quantity/with_self/ustrip 3.1 ± 0.01 ns 2.79 ± 0.01 ns 1.11 ± 0.0054
QuantityArray/broadcasting/multi_array_of_quantities 0.143 ± 0.0029 ms 0.141 ± 0.0019 ms 1.01 ± 0.025
QuantityArray/broadcasting/multi_normal_array 0.0557 ± 0.0031 ms 0.0558 ± 0.0031 ms 0.998 ± 0.078
QuantityArray/broadcasting/multi_quantity_array 0.157 ± 0.00083 ms 0.155 ± 0.00096 ms 1.01 ± 0.0082
QuantityArray/broadcasting/x^2_array_of_quantities 23.5 ± 1.7 μs 24.7 ± 1.6 μs 0.95 ± 0.093
QuantityArray/broadcasting/x^2_normal_array 4.94 ± 0.77 μs 5.36 ± 0.81 μs 0.922 ± 0.2
QuantityArray/broadcasting/x^2_quantity_array 6.93 ± 0.31 μs 6.98 ± 0.35 μs 0.993 ± 0.067
QuantityArray/broadcasting/x^4_array_of_quantities 0.0814 ± 0.0012 ms 0.0814 ± 0.00057 ms 0.999 ± 0.016
QuantityArray/broadcasting/x^4_normal_array 0.0498 ± 0.00016 ms 0.0498 ± 0.00019 ms 0.999 ± 0.005
QuantityArray/broadcasting/x^4_quantity_array 0.0499 ± 0.00018 ms 0.0529 ± 0.0002 ms 0.943 ± 0.005
time_to_load 0.185 ± 0.00074 s 0.195 ± 0.0014 s 0.948 ± 0.0079
Memory benchmarks
main fa4510a... main / fa4510a...
Quantity/creation/Quantity(x) 0 allocs: 0 B 0 allocs: 0 B
Quantity/creation/Quantity(x, length=y) 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/*real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int * real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity/+y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity//y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/dimension 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/inv 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/ustrip 0 allocs: 0 B 0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/multi_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/multi_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^2_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^2_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^2_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^4_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^4_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^4_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@d262170). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ext/DynamicQuantitiesLinearAlgebraExt.jl 0.00% 3 Missing ⚠️
src/arrays.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage        ?   98.83%           
=======================================
  Files           ?       21           
  Lines           ?     1284           
  Branches        ?        0           
=======================================
  Hits            ?     1269           
  Misses          ?       15           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver icweaver marked this pull request as draft August 30, 2025 20:23
@icweaver icweaver closed this Aug 30, 2025
@icweaver icweaver changed the title Additional QuantityArray constructions Additional QuantityArray constructions [EXPERIMENT] Aug 30, 2025
@icweaver icweaver deleted the quantityarray branch August 30, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QuantityArray convenience

1 participant