LibWeb: Fixes to inherited style recomputation & transitions #6837
+223
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
Calme1709
force-pushed
the
more-transition-fixes
branch
from
345c742 to
b076f39
Compare
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
Calme1709
force-pushed
the
more-transition-fixes
branch
from
b076f39 to
6d35692
Compare
github-actions
bot
removed
the
conflicts
Contributor
Author
|
Rebased to resolve conflicts |
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
Reduces the rebuild required when editing this file
Previously we assumed that if the non-animated value was inherited then the animated value must be also which is not true.
We only need to consider the change in the value that is actually used, not the animated and non-animated values individually
We were missing the important flag here so would always reset it to false
We can achieve the same thing by using `parse_simple_comma_separated_value_list`
CSS transitions have a higher precedence in the cascade than important properties
Calme1709
force-pushed
the
more-transition-fixes
branch
from
6d35692 to
c2e6308
Compare
github-actions
bot
removed
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a messy PR combined into one to avoid merge conflicts, includes:
recompute_inherited_styleSee individual commits for details.