-
Notifications
You must be signed in to change notification settings - Fork 251
DEVREL-916 fix (examples/oapp-solana): update message library PDAs and config PDAs checks #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Testing: |
DanL0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
Problem
Running the wire task might result in
Diagnosis:
init-configprior to running the wire taskBackground
For a Solana OApp wiring to work, there are two types of PDAs that are needed: Send/Receive Library PDAs (owned by Endpoint program) and ULN Config PDAs (owned by the ULN program)
#1645 fixed an issue that would appear during wiring where init-config would falsely report that all PDAs were initialized (bug introduced by a change upstream) when in fact they were not, resulting in an error when running the wire command. This PR however applied the fix only for oft-solana, but not for oapp-solana.
The fix involves updating
sendConfigIsInitializedto also check send/library config accounts. We need the same for oapp-solana.Changes
Instead of checking only for ULN config accounts, we should also check for send/receive library config accounts.