Set login form to post, in case js errors prevent submit cancelation #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an update from 1.0.0 to 1.2.0-beta7 the jQuery script was missing. (I had it set to load from local) This made the login form submit via GET and thus showed my password in the URI. With this change it would mitigate this data leakage (bystanders seeing my password)
WebCrew
approved these changes
Sep 18, 2020
Contributor
WebCrew
left a comment
WebCrew
left a comment
There was a problem hiding this comment.
all is done well could be verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an update from 1.0.0 to 1.2.0-beta7 the jQuery script was missing. (I had it set to load from local)
This made the login form submit via GET and thus showed my password in the URI. With this change it would mitigate this data leakage (bystanders seeing my password)
Pull Request Summary
Only added post as method to the login form