-
Notifications
You must be signed in to change notification settings - Fork 661
Source gen maps #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source gen maps #1998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the LiveCharts codebase to implement a source generation approach for map charts across multiple UI frameworks. The changes introduce generated code for GeoMap components, consolidate common functionality, and create a new IDrawnView interface to share drawing-related properties between chart and map views.
Key changes:
- Introduces a source generation approach for map chart components
- Creates
IDrawnViewinterface to extract common drawing properties fromIChartView - Refactors existing chart implementations to use the new interface hierarchy
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
Multiple platform GeoMap.cs files |
Simplified to inherit from generated base classes instead of implementing full functionality |
Generated SourceGenMapChart files |
New source-generated base classes providing platform-specific map chart implementations |
IDrawnView.cs |
New interface extracting common drawing properties (CoreCanvas, ControlSize) |
IChartView.cs |
Refactored to inherit from IDrawnView instead of defining drawing properties directly |
| Various platform-specific files | Updated to reference IDrawnView properties instead of IChartView properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/LiveChartsGeneratedCode/SourceGenChart.cs
Show resolved
Hide resolved
src/skiasharp/LiveChartsCore.SkiaSharp.WPF/LiveChartsGeneratedCode/SourceGenMapChart.cs
Outdated
Show resolved
Hide resolved
src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/LiveChartsGeneratedCode/SourceGenSKMapChart.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…Code/SourceGenMapChart.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…ratedCode/SourceGenSKMapChart.cs Co-authored-by: Copilot <[email protected]>
No description provided.