Skip to content

Conversation

@lazarusA
Copy link
Member

@lazarusA lazarusA commented Jun 7, 2025

lowering the priority for the latex mime fixes MakieOrg/AlgebraOfGraphics.jl#664

However, I still don't see the use case for that? what is the specific scenario for this?

??

```@example latex
f(x) = 2x # and latex somehow?
```

@asinghvi17 what is the specific example? so that we can include it in the docs.

@jkrumbiegel this seems to work. I added a DataFrame example, can you think of another obvious use case that should always work? more Tables stuff?

Edit: Ok, I tested locally also SummaryTables, all good.

@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 7.73%. Comparing base (dafa189) to head (c889bea).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/writer.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #279   +/-   ##
======================================
  Coverage    7.73%   7.73%           
======================================
  Files           6       6           
  Lines         892     892           
======================================
  Hits           69      69           
  Misses        823     823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asinghvi17
Copy link
Collaborator

All the DiffEq/ModelingToolkit stuff. But you can return a latexstring for testing...thanks for PRing!

@lazarusA
Copy link
Member Author

lazarusA commented Jun 7, 2025

I don't need all, only one representative example 😉!

@jkrumbiegel
Copy link
Collaborator

I was just concerned that vitepress isn't able to handle all latex (like real latex would) so that sometimes the plain text might be preferable. But I guess if it works most of the time that's still useful, as long as the priority is low. So I'm fine with the change here.

We should think about actual rendering tests for this stuff at some point.

@lazarusA lazarusA merged commit fed5b13 into master Jun 8, 2025
6 of 7 checks passed
@lazarusA lazarusA deleted the la/latex branch June 8, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial page not rendered properly

4 participants