Skip to content

Conversation

@abhro
Copy link
Contributor

@abhro abhro commented Nov 25, 2025

1.10 is the current LTS release and compatibility with 1.6 cannot be maintained

1.10 is the current LTS release and compatibility with 1.6 cannot be maintained
@gemini-code-assist
Copy link

Summary of Changes

Hello @abhro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's minimum supported Julia version to 1.10. This change is driven by the fact that 1.10 is the current LTS release, and maintaining compatibility with the older 1.6 version is no longer sustainable. The update ensures the project can leverage modern features and benefits from ongoing support and stability.

Highlights

  • Julia Version Update: The minimum supported Julia version has been updated from 1.6 to 1.10, aligning with the current Long Term Support (LTS) release.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported Julia version from 1.6 to 1.10 in Project.toml. This change aligns the project with the current Long-Term Support (LTS) version of Julia. The modification is correct and I have no further feedback.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.73%. Comparing base (f1e37d3) to head (08b15c1).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #292   +/-   ##
======================================
  Coverage    7.73%   7.73%           
======================================
  Files           6       6           
  Lines         892     892           
======================================
  Hits           69      69           
  Misses        823     823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abhro
Copy link
Contributor Author

abhro commented Nov 25, 2025

CI succeeded here on Julia 1.6 because it used 1.6.7 instead of 1.6.0 as in #291. So the issue was probably taken care of on a patch release. But still, given that 1.6 is out of support, we should probably raise the minimum version to 1.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant