-
Notifications
You must be signed in to change notification settings - Fork 17
Bump minimum supported julia version to 1.10 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1.10 is the current LTS release and compatibility with 1.6 cannot be maintained
Summary of ChangesHello @abhro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's minimum supported Julia version to 1.10. This change is driven by the fact that 1.10 is the current LTS release, and maintaining compatibility with the older 1.6 version is no longer sustainable. The update ensures the project can leverage modern features and benefits from ongoing support and stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the minimum supported Julia version from 1.6 to 1.10 in Project.toml. This change aligns the project with the current Long-Term Support (LTS) version of Julia. The modification is correct and I have no further feedback.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
======================================
Coverage 7.73% 7.73%
======================================
Files 6 6
Lines 892 892
======================================
Hits 69 69
Misses 823 823 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI succeeded here on Julia 1.6 because it used 1.6.7 instead of 1.6.0 as in #291. So the issue was probably taken care of on a patch release. But still, given that 1.6 is out of support, we should probably raise the minimum version to 1.10? |
1.10 is the current LTS release and compatibility with 1.6 cannot be maintained